Check generic crop parameter values

[linniahawkins]

For CLM BGC no crop (16 pft) compsets the parameter values for C3 irrigated and C3 non-irrigated crops should be identical to the generic C3 grass.

@linniahawkins Needs to check and fix this in the parameter file. Assign this to me when it is appropriate to make the change.

[ekluzek]

I was looking for issues that need changes to answers, and this is one of the ones I found.

I used query_paramfile (very nice to use by the way) to look at PFT variables that have differences between the generic grass and c3_crop or c3_irrigated values (removing a few that don't apply like irrigate), and came up with this list:

slatop:
   c3_non-arctic_grass: 0.03991
   c3_crop            : 0.03991
   c3_irrigated       : 0.04024
leafcn:
   c3_non-arctic_grass: 29.39
   c3_crop            : 26.22
   c3_irrigated       : 25.0
xl:
   c3_non-arctic_grass: -0.23
   c3_crop            : 0.3
   c3_irrigated       : 0.3
theta_cj:
   c3_non-arctic_grass: 0.9393
   c3_crop            : 0.9393
   c3_irrigated       : 0.98
FUN_fracfixers:
   c3_non-arctic_grass: 0.25
   c3_crop            : 0.0
   c3_irrigated       : 0.0
akc_active:
   c3_non-arctic_grass: 0.006
   c3_crop            : 0.006
   c3_irrigated       : 0.06
akn_active:
   c3_non-arctic_grass: 0.012
   c3_crop            : 0.012
   c3_irrigated       : 0.12
dleaf:
   c3_non-arctic_grass: 0.001352
   c3_crop            : 0.008371
   c3_irrigated       : 0.04
ekc_active:
   c3_non-arctic_grass: 0.036
   c3_crop            : 0.036
   c3_irrigated       : 0.36
ekn_active:
   c3_non-arctic_grass: 0.006
   c3_crop            : 0.006
   c3_irrigated       : 0.06
flnr:
   c3_non-arctic_grass: 0.1365
   c3_crop            : 0.1758
   c3_irrigated       : 0.1758
froot_leaf:
   c3_non-arctic_grass: 1.57
   c3_crop            : 1.57
   c3_irrigated       : 1.0
fsr_pft:
   c3_non-arctic_grass: 0.0484
   c3_crop            : 0.0484
   c3_irrigated       : 0.042
i_vcad:
   c3_non-arctic_grass: 6.42
   c3_crop            : 4.71
   c3_irrigated       : 4.71
jmaxb0:
   c3_non-arctic_grass: 0.0291
   c3_crop            : 0.0291
   c3_irrigated       : 0.0311
jmaxb1:
   c3_non-arctic_grass: 0.13
   c3_crop            : 0.13
   c3_irrigated       : 0.17
kc_nonmyc:
   c3_non-arctic_grass: 0.0012
   c3_crop            : 0.0012
   c3_irrigated       : 0.012
kn_nonmyc:
   c3_non-arctic_grass: 0.072
   c3_crop            : 0.072
   c3_irrigated       : 0.72
krmax:
   c3_non-arctic_grass: 2.077389772217998e-08
   c3_crop            : 9.559137874869126e-10
   c3_irrigated       : 7.943282347242822e-10
leaf_long:
   c3_non-arctic_grass: 0.31
   c3_crop            : 0.31
   c3_irrigated       : 1.0
lmr_intercept_atkin:
   c3_non-arctic_grass: 2.35
   c3_crop            : 2.35
   c3_irrigated       : 2.2
medlynintercept:
   c3_non-arctic_grass: 5063.54
   c3_crop            : 5063.54
   c3_irrigated       : 100.0
medlynslope:
   c3_non-arctic_grass: 8.32
   c3_crop            : 7.4
   c3_irrigated       : 5.79
pftpar28:
   c3_non-arctic_grass: -17.0
   c3_crop            : nan
   c3_irrigated       : nan
pftpar29:
   c3_non-arctic_grass: 15.5
   c3_crop            : nan
   c3_irrigated       : nan
r_mort:
   c3_non-arctic_grass: 0.019993579439385133
   c3_crop            : 0.019993579439385133
   c3_irrigated       : 0.02
rholnir:
   c3_non-arctic_grass: 0.28
   c3_crop            : 0.42
   c3_irrigated       : 0.42
rholvis:
   c3_non-arctic_grass: 0.05
   c3_crop            : 0.08
   c3_irrigated       : 0.08
roota_par:
   c3_non-arctic_grass: 11.0
   c3_crop            : 6.0
   c3_irrigated       : 6.0
rootb_par:
   c3_non-arctic_grass: 2.0
   c3_crop            : 3.0
   c3_irrigated       : 3.0
s_vcad:
   c3_non-arctic_grass: 40.96
   c3_crop            : 59.23
   c3_irrigated       : 59.23
z0v_Cr:
   c3_non-arctic_grass: 0.0399999991
   c3_crop            : 0.0500000007
   c3_irrigated       : 0.05
z0v_LAImax:
   c3_non-arctic_grass: 4.61000013
   c3_crop            : 5.30000019
   c3_irrigated       : 5.30000019
z0v_c:
   c3_non-arctic_grass: 0.0799999982
   c3_crop            : 0.0399999991
   c3_irrigated       : 0.0399999991
z0v_cw:
   c3_non-arctic_grass: 19.0
   c3_crop            : 3.5
   c3_irrigated       : 3.5

@linniahawkins and @wwieder do we just need to update the parameter file to have all of the above values agree with the c3_non-arctic_grass version? That would be straightforward to do if so.

[wwieder]

Also interested to hear from @samsrabin here? Should we discuss at the CLM meeting today?

[samsrabin]

Nice, thanks for finding all these @ekluzek. Note also this from Danica on the related discussion (Updating generic crop parameters?):

My recollection is that some of the parameters were updated to be more similar to crops, which tend to be more productive than grasses. We could test the updated grass parameters to see how things change though.

[wwieder]

I'm still fuzzy on what we want to do on what timeline for this. Maybe it's not critical for beta08, but is beta09 an appropriate milestone? Would a synchronous discussion at a science meeting be helpful?

[samsrabin]

Yeah, it'd be helpful to discuss this at a science meeting. Definitely not critical for beta08.

[wwieder]

great. I added it to our data nugget slot for next week's meeting

[ekluzek]

@danicalombardozzi gave me some notes based on today's CLM Science meeting and a point she wanted to make about FUN and Nitrogen fixing.

• It’s unclear why the param values are different for c3_crop & c3_irrig. Sometimes it’s an order of magnitude
• We discussed having many crop parameters being the same as for C3 non-arctic grass.
• C3 crops should have higher productivity. For SP, this might be the Vcmax variable, for BGC no-crop, it might be leaf C/N.
• I also think we need to keep FUN frac N fixers parameter to 0 for crops, or figure out what it should be (e.g., what proportion of crop area is typically n-fixing0. Soy is the big N fixer, but most crops are not N fixers.

[ekluzek]

@linniahawkins I wasn't sure how this was going to be align with the other work you are doing on the parameter file. If I understand what will happen here, it's that the steps will be:

1. Make most c3_crop parameters the same as C3 non-arctic grass
2. Change c3_crop parameters for productivity (might be vcmax for SP and leaf C/N for BGC)
3. Make FUN frac N fixer to 0
4. make c2_crop and c3_irrig the same

A second project could then be to figure out what the FUN frac N fixer should be. It seems this should be based on the area in each grid cell for the crops that fix N over the total crop area (if I understand this correctly). This should be done as a seperate project though as it would require code changes.

I assume after you get the c3_crop/c3_irrig changes you'll merge the other tweaks you are working on. And part of that might include just changing c4_grass to the "wild" update you proposed today.

Let me know if that sounds about right, or if I missed something. It's probably easiest for us if you give us one parameter file that has everything you are working on. But, we could also bring parameter files in stages if that would help the process.