wip

Author: tim-smart

packages/cluster/src/Sharding.ts

@@ -1211,46 +1211,45 @@ const make = Effect.gen(function*() {
   const reaper = yield* EntityReaper
   const entityManagerLatches = new Map<string, Effect.Latch>()
 
-  const registerEntity: Sharding["Type"]["registerEntity"] = Effect.fnUntraced(
-    function*(entity, build, options) {
-      if (Option.isNone(config.runnerAddress) || entityManagers.has(entity.type)) return
-      const scope = yield* Scope.make()
-      yield* Scope.addFinalizer(
-        scope,
-        Effect.sync(() => {
-          state.closed = true
-        })
-      )
-      const manager = yield* EntityManager.make(entity, build, {
-        ...options,
-        storage,
-        runnerAddress: config.runnerAddress.value,
-        sharding
-      }).pipe(
-        Effect.provide(context.pipe(
-          Context.add(EntityReaper, reaper),
-          Context.add(Scope.Scope, scope),
-          Context.add(Snowflake.Generator, snowflakeGen)
-        ))
-      ) as Effect.Effect<EntityManager.EntityManager>
-      const state: EntityManagerState = {
-        entity,
-        scope,
-        closed: false,
-        manager
-      }
-      entityManagers.set(entity.type, state)
-      if (entityManagerLatches.has(entity.type)) {
-        entityManagerLatches.get(entity.type)!.unsafeOpen()
-        entityManagerLatches.delete(entity.type)
-      }
+  const registerEntity: Sharding["Type"]["registerEntity"] = Effect.fnUntraced(function*(
+    entity,
+    build,
+    options
+  ) {
+    if (Option.isNone(config.runnerAddress) || entityManagers.has(entity.type)) return
+    const scope = yield* Scope.make()
+    yield* Scope.addFinalizer(
+      scope,
+      Effect.sync(() => {
+        state.closed = true
+      })
+    )
+    const manager = yield* EntityManager.make(entity, build, {
+      ...options,
+      storage,
+      runnerAddress: config.runnerAddress.value,
+      sharding
+    }).pipe(
+      Effect.provide(context.pipe(
+        Context.add(EntityReaper, reaper),
+        Context.add(Scope.Scope, scope),
+        Context.add(Snowflake.Generator, snowflakeGen)
+      ))
+    ) as Effect.Effect<EntityManager.EntityManager>
+    const state: EntityManagerState = {
+      entity,
+      scope,
+      closed: false,
+      manager
+    }
+    entityManagers.set(entity.type, state)
+    if (entityManagerLatches.has(entity.type)) {
+      entityManagerLatches.get(entity.type)!.unsafeOpen()
+      entityManagerLatches.delete(entity.type)
+    }
 
-      yield* PubSub.publish(events, EntityRegistered({ entity }))
-    },
-    // register entities while storage is idle
-    // this ensures message order is preserved
-    withStorageReadLock
-  )
+    yield* PubSub.publish(events, EntityRegistered({ entity }))
+  })
 
   yield* Scope.addFinalizerExit(
     shardingScope,