Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blinding_derivation_key should be generated in HD path #130

Open
instagibbs opened this issue Feb 26, 2017 · 2 comments
Open

blinding_derivation_key should be generated in HD path #130

instagibbs opened this issue Feb 26, 2017 · 2 comments

Comments

@instagibbs
Copy link
Contributor

Currently all keys except the blinding derivation key are generated via HD wallet. Using GenerateNewKey would enable HD derivation of that key making backups easier, and would allow us to keep it encrypted like any other key when not in use.

@instagibbs instagibbs changed the title [0.13.1] blinding_derivation_key should be generated in HD path blinding_derivation_key should be generated in HD path Jul 25, 2017
@dgpv
Copy link
Contributor

dgpv commented Feb 22, 2019

for reference - relevant issues: #233 #448

@instagibbs
Copy link
Contributor Author

Note that anytime the wallet is encrypted for the first time, or for example sethdseed is called(elements-0.17), the derived key will become "old" and still require a proper backup. That, or we then have to store N-many master blinding keys, and try all of them(no thanks).

One safety measure could be to print out the master blinding key directly during dumpwallet right after the xprv, and allow it to be set using sethdseed or another possibly hidden RPC call, since it can be quite dangerous to call this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@instagibbs @dgpv and others