Skip to content

String overread on armhf #5283

Open
Open
@cdecker

Description

@cdecker

Issue and Steps to Reproduce

Compiling the PPA on Launchpad, results in the following error on armhf architectures:

closingd/closingd.o closingd/closingd.c
closingd/closingd.c: In function ‘main’:
closingd/closingd.c:1009:35: error: ‘receive_offer’ reading 128 bytes from a region of size 32 [-Werror=stringop-overread]
 1009 |                                 = receive_offer(pps, chainparams,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1010 |                                                 &channel_id, funding_pubkey,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1011 |                                                 funding_wscript,
      |                                                 ~~~~~~~~~~~~~~~~
 1012 |                                                 local_wallet_index,
      |                                                 ~~~~~~~~~~~~~~~~~~~
 1013 |                                                 local_wallet_ext_key,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~
 1014 |                                                 scriptpubkey, &funding,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~~~
 1015 |                                                 funding_sats,
      |                                                 ~~~~~~~~~~~~~
 1016 |                                                 out, opener,
      |                                                 ~~~~~~~~~~~~
 1017 |                                                 our_dust_limit,
      |                                                 ~~~~~~~~~~~~~~~
 1018 |                                                 min_fee_to_accept,
      |                                                 ~~~~~~~~~~~~~~~~~~
 1019 |                                                 wrong_funding,
      |                                                 ~~~~~~~~~~~~~~
 1020 |                                                 &closing_txid,
      |                                                 ~~~~~~~~~~~~~~
 1021 |                                                 their_feerange);
      |                                                 ~~~~~~~~~~~~~~~
closingd/closingd.c:1009:35: note: referencing argument 4 of type ‘const struct pubkey *’
closingd/closingd.c:231:1: note: in a call to function ‘receive_offer’
  231 | receive_offer(struct per_peer_state *pps,
      | ^~~~~~~~~~~~~
closingd/closingd.c:1076:35: error: ‘receive_offer’ reading 128 bytes from a region of size 32 [-Werror=stringop-overread]
 1076 |                                 = receive_offer(pps, chainparams, &channel_id,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1077 |                                                 funding_pubkey,
      |                                                 ~~~~~~~~~~~~~~~
 1078 |                                                 funding_wscript,
      |                                                 ~~~~~~~~~~~~~~~~
 1079 |                                                 local_wallet_index,
      |                                                 ~~~~~~~~~~~~~~~~~~~
 1080 |                                                 local_wallet_ext_key,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~
 1081 |                                                 scriptpubkey, &funding,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~~~
 1082 |                                                 funding_sats,
      |                                                 ~~~~~~~~~~~~~
 1083 |                                                 out, opener,
      |                                                 ~~~~~~~~~~~~
 1084 |                                                 our_dust_limit,
      |                                                 ~~~~~~~~~~~~~~~
 1085 |                                                 min_fee_to_accept,
      |                                                 ~~~~~~~~~~~~~~~~~~
 1086 |                                                 wrong_funding,
      |                                                 ~~~~~~~~~~~~~~
 1087 |                                                 &closing_txid,
      |                                                 ~~~~~~~~~~~~~~
 1088 |                                                 their_feerange);
      |                                                 ~~~~~~~~~~~~~~~
closingd/closingd.c:1076:35: note: referencing argument 4 of type ‘const struct pubkey *’
closingd/closingd.c:231:1: note: in a call to function ‘receive_offer’
  231 | receive_offer(struct per_peer_state *pps,
      | ^~~~~~~~~~~~~

This is on tag ppa-v0.11.1 with gcc-11 armhf 11.3.0-3ubuntu1 installed.

Full logs can be found at https://launchpadlibrarian.net/602589777/buildlog_ubuntu-kinetic-armhf.lightningd_0.11.1ubuntu1~202205221237~ubuntu22.10.1_BUILDING.txt.gz

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions