make endian functions generic to work with any type

Author: EmilDohne

PhotoshopAPI/CMakeLists.txt

@@ -34,7 +34,11 @@ if(MSVC)
     # w45264 is for using std:move when returning a temporary.
     target_compile_options(PhotoshopAPI PRIVATE /W4 /WX /w44062 /w44464 /w45264)
 else()
-    target_compile_options(PhotoshopAPI PUBLIC -O3)
+    if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+        target_compile_options(PhotoshopAPI PUBLIC -O3 -Wuninitialized -Wmaybe-uninitialized)
+    else()
+        target_compile_options(PhotoshopAPI PUBLIC -O3)
+    endif()
     include(CheckCXXCompilerFlag)
     check_cxx_compiler_flag("-mavx2" COMPILER_SUPPORTS_AVX2)
     if(COMPILER_SUPPORTS_AVX2)

PhotoshopAPI/src/Core/Compression/Compress_RLE.h

@@ -416,13 +416,13 @@ std::vector<uint8_t> CompressRLE(std::vector<T>& uncompressedData, const FileHea
                     PSAPI_LOG_ERROR("CompressRLE", "Scanline sizes cannot exceed the numeric limits of 16-bit values when writing a PSD file");
                 }
                 uint16_t scanlineSizeu16 = static_cast<uint16_t>(scanlineSize);
-                scanlineSizeu16 = endianEncodeBE(scanlineSizeu16);
+                scanlineSizeu16 = endian_encode_be(scanlineSizeu16);
                 // Set the data at the correct index
                 std::memcpy(reinterpret_cast<void*>(compressedData.data() + scanlineIndex), &scanlineSizeu16, sizeof(uint16_t));
         }
         else
         {
-            scanlineSize = endianEncodeBE(scanlineSize);
+            scanlineSize = endian_encode_be(scanlineSize);
             std::memcpy(reinterpret_cast<void*>(compressedData.data() + scanlineIndex), &scanlineSize, sizeof(uint32_t));
         }