fix check and tests

Author: AdrienLeGuillou

R/workflow.R

@@ -38,7 +38,7 @@
 create_workflow <- function(wf_name, default_sbatch_opts,
                             wf_common_dir = "workflows") {
   sbatch_opts <- validate_sbatch_opts(default_sbatch_opts)
-  if (!"partition" %in% sbatch_opts)
+  if (!"partition" %in% names(sbatch_opts))
     stop("A `partition` option must be defined in `default_sbatch_opts`")
   wf_summary <- new_summary(fs::path(wf_common_dir, wf_name), sbatch_opts)
   create_wf_dir(wf_summary)

tests/testthat/test-add_workflow_step.R

@@ -17,6 +17,7 @@ test_that("`add_workflow_step` produces the right file structure", {
   wf <- create_workflow(
     wf_name = wf_name,
     default_sbatch_opts = list(
+      "partition" = "test_partition",
       "account" = "test_account"
     ),
     wf_common_dir = test_dir

tests/testthat/test-create_workflow.R

@@ -7,6 +7,7 @@ test_that("`create_workflow` produces the right file structure", {
   wf <- create_workflow(
     wf_name = wf_name,
     default_sbatch_opts = list(
+      "partition" = "dummy_part",
       "account" = "test_account"
     ),
     wf_common_dir = test_dir
@@ -35,17 +36,34 @@ test_that("`create_workflow` fails if a workflow with the same name already exis
   create_workflow(
     wf_name = wf_name,
     default_sbatch_opts = list(
-      "account" = "test_account"
+      "partition" = "test_partition"
     ),
     wf_common_dir = test_dir
   )
 
+  expect_error(
+    create_workflow(
+      wf_name = wf_name,
+      default_sbatch_opts = list(
+        "partition" = "test_partition"
+      ),
+      wf_common_dir = test_dir
+    )
+  )
+})
+
+test_that("`create_workflow` fails if no `partition` is selected", {
+  test_dir <- "workflows"
+  withr::local_file(test_dir)
+
+  wf_name <- "test_wf_part"
+
   expect_error(
     create_workflow(
       wf_name = wf_name,
       default_sbatch_opts = list(
         "account" = "test_account"
-        ),
+      ),
       wf_common_dir = test_dir
     )
   )