Spend-Username not shown when moving expense to self dm in offline.

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: V9.5.46
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #95994
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workspace chat
3. Create 2 manual expense
4. Go to spend
5. Go offline
6. Open first expense - Report and remove from report
7. Note username name disappears in moved unreported expense
8. Turn online
9. Note username name appears in moved unreported expense

Expected Result:

In Spend page, username must be shown when moving expense to self dm in offline.

Actual Result:

In Spend page, username not shown when moving expense to self dm in offline.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7221560_1785422839896.Screenrecorder-2026-07-30-20-15-53-789.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7221560

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022082846150142910179
• Upwork Job ID: 2082846150142910179
• Last Price Increase: 2026-07-30

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7c8dfe2a677683f09434dd56459bb2a44fb1ce3c952fcb6e3fcc0b4df375b0b5

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an expense is moved out of a report to the self-DM (Report and remove from report) while offline, the payer/username (and avatar) is blank for that expense in the Spend list. It renders correctly again once the app reconnects.

What is the root cause of that problem?

The Spend list is backed by the Search snapshot, and it resolves the from (payer) display name only from the snapshot's personalDetailsList — with no fallback to live Onyx.

• The move's optimistic path, getChangeTransactionsReportOnyxData in Transaction.ts, writes only to the live collections (REPORT / REPORT_ACTIONS / TRANSACTION). It never adds the actor to the search snapshot's personalDetailsList.
• By contrast, the create/track path does mirror the actor into the snapshot via getSearchOnyxUpdate — which is why created/tracked expenses show the name offline but moved ones don't.
• The display code resolves from from the stale snapshot map and falls to emptyPersonalDetails → blank name/avatar. Note the to field already has a live-Onyx fallback here, but from does not:

Evidence (file:line)

• from is resolved from the snapshot personalDetailsList only: SearchUIUtils.ts:2185, SearchUIUtils.ts:2227-2228.
• Asymmetric fallback — from has no live fallback, to does: SearchUIUtils.ts:1221-1229. The grouped expense-report variant also falls back to live Onyx via getPersonalDetailsForAccountID: SearchUIUtils.ts:2957-2960.
• actorAccountID is preserved on the optimistic action, so the missing piece is the personal details, not the account ID: Transaction.ts:1128-1144.
• Optimistic search injection surfaces the row (live transaction + report action) but not personalDetails: useOptimisticSearchTracking.ts:160-184.
• With emptyPersonalDetails (fake accountID, undefined name) the cell renders nothing: TransactionItemRowWide.tsx:404-409.

On reconnect the Search API response rewrites the snapshot personalDetailsList including the actor, so the name reappears.

What changes do you think we should make in order to solve the problem?

Give the flat-transaction from the same live-Onyx fallback the to field already has, so a stale/incomplete snapshot doesn't blank the payer.

In getTransactionItemCommonFormattedProperties, when from yields no name but a real accountID is known, look it up via getPersonalDetailsForAccountID(...) — mirroring the existing to fallback. Also resolve from at SearchUIUtils.ts:2227-2228 with a live fallback so from.accountID is real (the UserInfoCell needs it), e.g. reuse the mergedPersonalDetails (live + snapshot) approach already used by the expense-report variant.

This is symmetric with code already in the file and also fixes any other snapshot-staleness case, not just this move.

What alternative solutions did you explore?

Make the move's optimistic path emit SNAPSHOT updates including PERSONAL_DETAILS_LIST for the actor (plus the destination self-DM report and its new action), analogous to getSearchOnyxUpdate. This is a valid data-layer fix but narrower — it only covers this move flow, whereas the display-side fallback also hardens every other case where the snapshot lags live Onyx.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/97481) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022082846150142910179

[melvin-bot]

@Ollyws Eep! 4 days overdue now. Issues have feelings too...

[Ollyws]

will get to this asap.

[melvin-bot]

@Ollyws Huh... This is 4 days overdue. Who can take care of this?