The output of the md5(), sha1() and sha256() generators is misleading

[TimWolla]

Summary

The md5(), sha1() and sha256() generators are documented to return a random MD5, SHA-1 or SHA-256 hash respectively. This is technically true, but at the same time it's also misleading, because the functions are unable to leverage the full output space of the respective hashes the way they're written. They don't return a random hash, they return the hash of a random 32 bit integer which is something entirely different.

I'm skipping the remainder of the template, because the issue is evident by looking at the code:

Faker/src/Faker/Provider/Miscellaneous.php

Lines 245 to 273 in 57e1f99

	/**
	* @example 'cfcd208495d565ef66e7dff9f98764da'
	*
	* @return string
	*/
	public static function md5()
	{
	return md5(self::numberBetween());
	}
	/**
	* @example 'b5d86317c2a144cd04d0d7c03b2b02666fafadf2'
	*
	* @return string
	*/
	public static function sha1()
	{
	return sha1(self::numberBetween());
	}
	/**
	* @example '85086017559ccc40638fcde2fecaf295e0de7ca51b7517b6aebeaaf75b4d4654'
	*
	* @return string
	*/
	public static function sha256()
	{
	return hash('sha256', self::numberBetween());
	}

Possible solution:

Replace the implementation by bin2hex(random_bytes($bytes)) with $bytes being 16, 20 and 32 to make use of the entire output space [1]. But even then it would be slightly misleading, because hexadecimal is just one possible encoding for an 128/160/256 bit integer. Returning raw bytes or base64 encoding would also be valid representations that are actually used in practice in the context of a cryptographic hash.

[1] With PHP 8.2 use Randomizer::getBytes().

[kcassam]

Seems to me that there is no need to use bin2hex(). random_bytes($bytes) returns a raw string of the desired lenght and does a better job.

[TimWolla]

random_bytes($bytes) returns a raw string of the desired lenght and does a better job.

The functions return hexadecimal characters, thus the output from random_bytes() needs to be hex encoded.

[kcassam]

The functions return hexadecimal characters, thus the output from random_bytes() needs to be hex encoded.

I don't see why.
Miscellaneous::md5, Miscellaneous::sha1 and Miscellaneous::sha256 return hexadecimal characters independently of their parameter/input

[TimWolla]

The bin2hex would replace the call to the hash function. Actually hashing is not necessary, the output is indistinguishable anyway.