Fixing records deserialization issue (#5094, parts of #4628) with read-access when json renamed to same property name (#5073)

Author: iifawzi

release-notes/CREDITS-2.x

@@ -1885,3 +1885,8 @@ Zhen Lin Low (@zhenlin-pay2)
  * Reported, fixed #4920: Creator properties are ignored on abstract types
    when collecting bean properties, breaking AsExternalTypeDeserializer
   (2.18.3)
+
+Fawzi Essam (@iifawz)
+ * Contributed fix for #5049: Duplicate creator property "b" (index 0 vs 1)
+   on simple java record
+  (2.18.3)

release-notes/VERSION-2.x

@@ -4,6 +4,12 @@ Project: jackson-databind
 === Releases === 
 ------------------------------------------------------------------------
 
+2.18.4 (not yet released)
+
+#5049: Duplicate creator property "b" (index 0 vs 1) on simple java record
+ (reported by @richard-melvin)
+ (fix contributed by Fawzi E)
+
 2.18.3 (28-Feb-2025)
 
 #4444: The `KeyDeserializer` specified in the class with `@JsonDeserialize(keyUsing = ...)`
@@ -13,7 +19,7 @@ Project: jackson-databind
   index for property 'cause'
  (reported by @nilswieber)
  (fix by Joo-Hyuk K)
-#4844: Fix wrapped array hanlding wrt `null` by `StdDeserializer`
+#4844: Fix wrapped array handling wrt `null` by `StdDeserializer`
  (fix by Stanislav S)
 #4848: Avoid type pollution in `StringCollectionDeserializer`
  (contributed by Jonas K)

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

@@ -1798,7 +1798,7 @@ protected boolean _replaceCreatorProperty(List<POJOPropertyBuilder> creatorPrope
             POJOPropertyBuilder prop)
     {
         final AnnotatedParameter ctorParam = prop.getConstructorParameter();
-        if (creatorProperties != null) {
+        if (creatorProperties != null && ctorParam != null) {
             for (int i = 0, len = creatorProperties.size(); i < len; ++i) {
                 POJOPropertyBuilder cprop = creatorProperties.get(i);
                 if (cprop != null) {

src/test-jdk17/java/com/fasterxml/jackson/databind/records/RecordWithJsonIgnoreTest.java

@@ -61,12 +61,6 @@ public void testSerializeJsonIgnoreAndJsonPropertyRecord() throws Exception {
         assertEquals("{\"id\":123}", json);
     }
 
-    @Test
-    public void testDeserializeJsonIgnoreAndJsonPropertyRecord() throws Exception {
-        RecordWithIgnoreJsonProperty value = MAPPER.readValue("{\"id\":123,\"name\":\"Bob\"}", RecordWithIgnoreJsonProperty.class);
-        assertEquals(new RecordWithIgnoreJsonProperty(123, "Bob"), value);
-    }
-
     /*
     /**********************************************************************
     /* Test methods, JsonIgnore accessor

src/test-jdk17/java/com/fasterxml/jackson/databind/records/RecordWithReadOnlyTest.java

@@ -7,6 +7,8 @@
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
 
 public class RecordWithReadOnlyTest extends DatabindTestUtil {
 
@@ -50,6 +52,27 @@ public RecordWithReadOnlyAllAndNoArgConstructor() {
         }
     }
 
+
+    static class ReadOnly5049Pojo
+    {
+        protected String a, b;
+
+        ReadOnly5049Pojo(
+                @JsonProperty(value = "a", access = JsonProperty.Access.READ_ONLY) String a,
+                @JsonProperty(value = "b", access = JsonProperty.Access.READ_ONLY) String b) {
+            this.a = a;
+            this.b = b;
+        }
+
+        public String getA() { return a; }
+        public String getB() { return b; }
+    }
+
+    record ReadOnly5049Record(
+            @JsonProperty(value = "a", access = JsonProperty.Access.READ_ONLY) String a,
+            @JsonProperty(value = "b", access = JsonProperty.Access.READ_ONLY) String b) {
+    }
+
     private final ObjectMapper MAPPER = newJsonMapper();
 
     /*
@@ -82,14 +105,31 @@ public void testSerializeReadOnlyNamedProperty() throws Exception {
         assertEquals(a2q("{'id':123,'name':'Bob'}"), json);
     }
 
-    /**
-     * Currently documents a bug where a property was NOT ignored during deserialization if given an explicit name.
-     * Also reproducible in 2.14.x.
-     */
+
     @Test
     public void testDeserializeReadOnlyNamedProperty() throws Exception {
         RecordWithReadOnlyNamedProperty value = MAPPER.readValue(a2q("{'id':123,'name':'Bob'}"), RecordWithReadOnlyNamedProperty.class);
-        assertEquals(new RecordWithReadOnlyNamedProperty(123, "Bob"), value); // BUG: should be `null` instead of "Bob"
+        assertEquals(new RecordWithReadOnlyNamedProperty(123, null), value);
+    }
+
+    @Test
+    void testRoundtripPOJO() throws Exception
+    {
+        String json = MAPPER.writeValueAsString(new ReadOnly5049Pojo("hello", "world"));
+        ReadOnly5049Pojo pojo = MAPPER.readerFor(ReadOnly5049Pojo.class).readValue(json);
+        assertNotNull(pojo);
+        assertNull(pojo.a);
+        assertNull(pojo.b);
+    }
+
+    @Test
+    void testRoundtripRecord() throws Exception
+    {
+        String json = MAPPER.writeValueAsString(new ReadOnly5049Record("hello", "world"));
+        ReadOnly5049Record record = MAPPER.readValue(json, ReadOnly5049Record.class);
+        assertNotNull(record);
+        assertNull(record.a());
+        assertNull(record.b());
     }
 
     /*

src/test-jdk17/java/com/fasterxml/jackson/databind/tofix/RecordWIthJsonIgnoreAndValue4628Test.java

@@ -0,0 +1,39 @@
+package com.fasterxml.jackson.databind.tofix;
+
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.testutil.DatabindTestUtil;
+import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+// [databind#4628] @JsonIgnore is ignored with read access
+public class RecordWIthJsonIgnoreAndValue4628Test
+        extends DatabindTestUtil {
+
+    record RecordWithIgnoreJsonProperty(int id, @JsonIgnore @JsonProperty("name") String name) {
+    }
+
+    record RecordWithIgnoreJsonPropertyDifferentName(int id, @JsonIgnore @JsonProperty("name2") String name) {
+    }
+
+    private final ObjectMapper MAPPER = newJsonMapper();
+
+
+    // passing normally given different name is used
+    @Test
+    public void testDeserializeJsonIgnoreRecordWithDifferentName() throws Exception {
+        RecordWithIgnoreJsonPropertyDifferentName value = MAPPER.readValue("{\"id\":123,\"name\":\"Bob\"}", RecordWithIgnoreJsonPropertyDifferentName.class);
+        assertEquals(new RecordWithIgnoreJsonPropertyDifferentName(123, null), value);
+    }
+
+    @Test
+    @JacksonTestFailureExpected
+    public void testDeserializeJsonIgnoreAndJsonPropertyRecord() throws Exception {
+        RecordWithIgnoreJsonProperty value = MAPPER.readValue("{\"id\":123,\"name\":\"Bob\"}", RecordWithIgnoreJsonProperty.class);
+        assertEquals(new RecordWithIgnoreJsonProperty(123, null), value); // should be null, actual "bob"
+    }
+
+}