Skip to content

Commit 642bcea

Browse files
committed
Minor post-merge cleanup wrt #3053
1 parent d8922be commit 642bcea

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

src/main/java/com/fasterxml/jackson/databind/cfg/EnumFeature.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,12 @@ public enum EnumFeature implements DatatypeFeature
2929
* Enum values: if enabled, return value of <code>Enum.name().toLowerCase()</code>
3030
* is used; if disabled, return value of <code>Enum.name()</code> is used.
3131
*<p>
32+
* NOTE: this feature CAN NOT be changed on per-call basis: it will have to
33+
* be set on {@code ObjectMapper} before use
34+
*<p>
3235
* Feature is disabled by default.
36+
*
37+
* @since 2.15
3338
*/
3439
WRITE_ENUMS_TO_LOWERCASE(false);
3540

src/test/java/com/fasterxml/jackson/databind/ser/jdk/EnumSerializationTest.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,7 @@ public void testEnumWithJsonKey() throws Exception
332332
assertEquals(a2q("{'key:a':'value:b'}"), MAPPER.writeValueAsString(input2));
333333
}
334334

335+
// [databind#3053]
335336
public void testEnumFeature_WRITE_ENUMS_TO_LOWERCASE_isDisabledByDefault() {
336337
ObjectReader READER = MAPPER.reader();
337338
assertFalse(READER.isEnabled(EnumFeature.WRITE_ENUMS_TO_LOWERCASE));
@@ -343,12 +344,8 @@ public void testEnumFeature_WRITE_ENUMS_TO_LOWERCASE() throws Exception {
343344
ObjectMapper m = jsonMapperBuilder()
344345
.configure(EnumFeature.WRITE_ENUMS_TO_LOWERCASE, true)
345346
.build();
346-
assertEquals("\"b\"", m.writeValueAsString(TestEnum.B));
347-
348-
// [databind#749] but should also be able to dynamically disable
349-
assertEquals("\"B\"",
350-
m.writer().without(EnumFeature.WRITE_ENUMS_TO_LOWERCASE)
351-
.writeValueAsString(LowerCaseEnum.B));
347+
assertEquals(q("b"), m.writeValueAsString(TestEnum.B));
348+
// NOTE: cannot be dynamically changed
352349
}
353350
}
354351

src/test/java/com/fasterxml/jackson/databind/util/EnumValuesTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ public void testEnumResolver()
6666
assertEquals(ABC.C, enums.get(2));
6767
}
6868

69+
// [databind#3053]
6970
@SuppressWarnings("unchecked")
7071
public void testConstructFromNameLowerCased() {
7172
SerializationConfig cfg = MAPPER.getSerializationConfig()

0 commit comments

Comments
 (0)