-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add optional explicit JsonSubTypes
repeated names check
#3500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ok, sorry for the slow follow up. I hope to look into this in near future. PR is a good way to go! |
Hi @ancane! Ok, this took way longer than I hope for but now I am finally looking at this. I think this makes sense: I do have one request wrt annotation property naming, but otherwise it makes sense. But aside from that change (I'll add a comment in annotations PR), I need one other thing, CLA. It's here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and only needs to be sent once (works for all future contributions too); so if you had sent it earlier (I don't think so but I could have missed) that'd be fine. Thank you again for the contribution! |
@cowtowncoder Think I've done the code. Next will sort out the CLA. Ta! |
Sent a photo of the signed agreement to info mail as requested. |
Thanks! CLA received, I will proceed with merging. |
Merged the annotation patch, looking into #3501 here next. |
JsonSubTypes
repeated names check
Merged for inclusion in 2.14.0: thank you again, @ancane ! |
Cool! Thanks ever so much @cowtowncoder, it was my pleasure. |
Thank you @ancane and apologies for slow handling. But happy to get it done! |
Hi) Got a project at hand, using tons of JsonSubTypes with logical short names defined for the brevity of serialized data. Usually, it's pretty hard to manually check there are no repeated name/names aliases defined when adding a new subtype. I would like to explicitly state and validate there are no repeated subtype names defined. Please, consider related PR for this matter and suggest the best way to do this if PR is not good enough. I will also PR the annotations repo with the flag to enable the check.(FasterXML/jackson-annotations#204)
Also please advise, how to add this to the 2.12 branch if that's at all possible. Cheers!
The text was updated successfully, but these errors were encountered: