Skip to content

Pass one more argument to JsonSerializer.isEmpty() #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cowtowncoder opened this issue Oct 20, 2014 · 2 comments
Closed

Pass one more argument to JsonSerializer.isEmpty() #588

cowtowncoder opened this issue Oct 20, 2014 · 2 comments
Milestone

Comments

@cowtowncoder
Copy link
Member

Currently JsonSerializer.isEmpty() only takes a single argument, value to check.
But since some of configuration settings affect determination of emptiness (specifically, SerializationConfig.getSerializationInclusion()), it would make sense to pass SerializationConfig.
But it may be that some other per-call information will also be needed, so let's instead pass SerializerProvider, which gives full access to all available configuration.

Existing method needs to be deprecated, but supported for at least until 2.6 (and probably later); existing serializers should be upgrade in 2.5 to work with both methods.

@kellerassel007
Copy link

kellerassel007 commented Aug 14, 2018

solved

@cowtowncoder
Copy link
Member Author

@kellerassel007 Both issues are closed at this point: if there is a case that does not work with later versions (esp. 2.9.6), please file a new issue with reproduction. It may refer to this and/or 457 for context, but otherwise explain what is not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants