Skip to content
This repository was archived by the owner on Jan 22, 2019. It is now read-only.
This repository was archived by the owner on Jan 22, 2019. It is now read-only.

Allow multi-character separator values #92

Description

@dharaburda

It would be useful if the array element separator could be defined using multiple characters (we frequently use ::). Seems reasonable to allow this for the column separator as well.

I am happy to make this change and submit a pull request.

It would be helpful to know what parts of the current API need to be preserved (and perhaps @Deprecated?). For example the inner classes CsvSchema.Builder and CsvSchema.Column are public, but don't appear to be intended for end-user use? I am assuming the method signatures on those could change without a problem. Obviously I would want to preserve mutant factory methods directly on CsvSchema.

It also appears that in this class at least, char[] is preferred? Using String would be a little more straightforward and also allow for an easy "disabled" value (empty string).

Thoughts? @cowtowncoder

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions