`OffsetDateTime`deserialization fails when using (specific?) date-time pattern #279

cristibozga · 2023-09-01T11:13:37Z

If we have an OffsetDateTime property inside a DTO where we specify the pattern, the deserialization operation fails:
Ex:
Inside OffsetDateDto:

   private OffsetDateTime date= OffsetDateTime.now(ZoneId.of("UTC")).truncatedTo(ChronoUnit.SECONDS);

    @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd'T'HH:mm:ss'Z'")
    public OffsetDateTime getDate() {
        return date;
    }
    public void setDate(OffsetDateTime date) {
        this.date = date;
    }

The code of the application:

           ObjectMapper o = new ObjectMapper();
            o.findAndRegisterModules();
            OffsetDateDto dto = new OffsetDateDto();
            StringWriter w = new StringWriter();
            o.writeValue(w, dto);
            String s = w.toString();
            System.out.println(s);
            OffsetDateDto x = o.readValue(s.getBytes(StandardCharsets.UTF_8), OffsetDateDto.class);

When we write the value (serialize dto I get displayed: '{"date":"2023-09-01T11:07:48Z",...'}
But the last line throws an error because deserialization fails:

com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `java.time.OffsetDateTime` from String "2023-09-01T11:07:48Z": Failed to deserialize java.time.OffsetDateTime: (java.time.DateTimeException) Unable to obtain OffsetDateTime from TemporalAccessor: {},ISO resolved to 2023-09-01T11:07:48 of type java.time.format.Parsed
 at [Source: (byte[])"{"date":"2023-09-01T11:07:48Z","localDate":"2023-09-01","localDateTime":"2023-09-01T11:07:48.7458067"}"; line: 1, column: 9] (through reference chain: json.OffsetDateDto["date"])
	at com.fasterxml.jackson.databind.exc.InvalidFormatException.from(InvalidFormatException.java:67)
	at com.fasterxml.jackson.databind.DeserializationContext.weirdStringException(DeserializationContext.java:1991)
	at com.fasterxml.jackson.databind.DeserializationContext.handleWeirdStringValue(DeserializationContext.java:1219)
	at com.fasterxml.jackson.datatype.jsr310.deser.JSR310DeserializerBase._handleDateTimeException(JSR310DeserializerBase.java:176)
	at com.fasterxml.jackson.datatype.jsr310.deser.InstantDeserializer._fromString(InstantDeserializer.java:307)
	at com.fasterxml.jackson.datatype.jsr310.deser.InstantDeserializer.deserialize(InstantDeserializer.java:217)
	at com.fasterxml.jackson.datatype.jsr310.deser.InstantDeserializer.deserialize(InstantDeserializer.java:51)
	at com.fasterxml.jackson.databind.deser.impl.MethodProperty.deserializeAndSet(MethodProperty.java:129)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:313)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:176)
	at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:322)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4674)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3690)
	at json.JsonObjectMapperTester.testOffsetDate(JsonObjectMapperTester.java:60)
	at a.Starter.main(Starter.java:21)
Caused by: java.time.DateTimeException: Unable to obtain OffsetDateTime from TemporalAccessor: {},ISO resolved to 2023-09-01T11:07:48 of type java.time.format.Parsed
	at java.base/java.time.OffsetDateTime.from(OffsetDateTime.java:372)
	at com.fasterxml.jackson.datatype.jsr310.deser.InstantDeserializer._fromString(InstantDeserializer.java:302)
	... 10 more
Caused by: java.time.DateTimeException: Unable to obtain ZoneOffset from TemporalAccessor: {},ISO resolved to 2023-09-01T11:07:48 of type java.time.format.Parsed
	at java.base/java.time.ZoneOffset.from(ZoneOffset.java:350)
	at java.base/java.time.OffsetDateTime.from(OffsetDateTime.java:361)
	... 11 more

I've tried also with the pattern 'yyyy-MM-dd'T'HH:mm:ssX' and I get the same error.
Am I doing something wrong here?

Thanks in advance

The text was updated successfully, but these errors were encountered:

phoebe-lew · 2023-10-03T04:26:40Z

Had the same issue and fixed it by updating the pattern to "yyyy-MM-dd'T'HH:mm:ss.SSSXXX", but did not dig into why "yyyy-MM-dd'T'HH:mm:ss'Z'" doesn't work when OffsetDateTime.parse() is fine with a string in the yyyy-MM-dd'T'HH:mm:ss'Z' format.

jaymanik · 2024-07-12T20:45:37Z

I faced error similar to what is posted above, when I upgraded lombok from '1.18.12' to '1.18.30'.
In my project, Tests which were working fine earlier started failing with deserialization error after the lombok version upgrade.
Error fixed itself when I downgraded back the lombok version.

So, I think this has something to do with one of the transitive dependencies not being compatible.

Jdk 8 Azul Zulu
Jackson2:2.10.1 library version
jackson-annotations component

cowtowncoder · 2024-07-13T00:16:52Z

Including JDK version for failing case would be useful as well. And obviously Jackson versions (plus need to ensure Jackson versions of components are aligned).

Lombok version discrepancy sounds odd, but could be due to Lombok's changing Jackson annotations it adds.

jaymanik · 2024-07-16T16:15:25Z

Including JDK version for failing case would be useful as well. And obviously Jackson versions (plus need to ensure Jackson versions of components are aligned).

Lombok version discrepancy sounds odd, but could be due to Lombok's changing Jackson annotations it adds.

Added details in my original comment.
What I could not understand is that before and after Lombok upgrade, Jackson2 library version was same.

cowtowncoder · 2024-07-17T02:16:03Z

@jaymanik Jackson 2.10 is very old version, as the latest is 2.17.2. So I would try out version upgrade first.

But I also realized that the original issue did not refer to Lombok so not sure if @jaymanik 's problem is same as @cristibozga's.

jaymanik · 2024-07-17T06:54:35Z

@jaymanik Jackson 2.10 is very old version, as the latest is 2.17.2. So I would try out version upgrade first.

But I also realized that the original issue did not refer to Lombok so not sure if @jaymanik 's problem is same as @cristibozga's.

Thank you for your suggestion. I will try to upgrade jackson2 and give it a try.

Apologies for not sharing stack trace.
We are not allowed to add GitHub comments from my work machine.

cristibozga · 2024-07-24T13:26:41Z

Sorry for missing some important data. So:
Jackson version is 2.13.5
JDK version is 17

Including JDK version for failing case would be useful as well. And obviously Jackson versions (plus need to ensure Jackson versions of components are aligned).

Lombok version discrepancy sounds odd, but could be due to Lombok's changing Jackson annotations it adds.

cowtowncoder · 2024-07-24T16:49:33Z

Jackson 2.13 is still old enough version that it'd definitely make sense to try with 2.17(.2) just rule out possibility of a fix.

cowtowncoder · 2024-08-15T22:06:47Z

Ok; verified the issue exists in 2.18 branch; added failing test as well -- don't have time to look deeper but hopefully this helps whoever decides to work on it.

JooHyukKim · 2025-03-10T23:01:32Z

@cowtowncoder This seems like good start for JSTEP5?

cowtowncoder · 2025-03-10T23:36:06Z

@JooHyukKim Worth fixing, could be part, sure.

JooHyukKim · 2025-03-12T14:45:56Z

Issue here is we are currently using OffsetDatetime.from(Temporal), where it requires both a date-time and an explicit offset (ZoneOffset), but we do not resolve offset.

cowtowncoder · 2025-03-12T16:12:20Z

@JooHyukKim ok. Do you think this is possible/easy to fix?

JooHyukKim · 2025-03-12T16:21:38Z

Possible, yes. Clean? I don't know. My understanding around API's related to time isn't sufficient, but sure. Since

I just tested if we do serialize...

String string = "2025-03-12T16:15:03Z" // this is what we get from serialization
OffsetDateTime result = OffsetDateTime.from(DateTimeFormatter.ISO_OFFSET_DATE_TIME.parse(string))

... this way it works. Meaning we may have to modify JSR310DateTimeDeserializerBase<?> _withFormatOverrides() logic.

@cowtowncoder One question tho, I am confused if "2025-03-12T16:15:03Z" is the right ser output? I am wondering why there is no 'Z' at the end, as specified by @JsonFormat.

cowtowncoder · 2025-03-13T01:09:10Z

@JooHyukKim Hmm? Your output does have Z? Although TBH, format having

'Z'

seems odd as that is hard-coded "Z", and not (I think?) timezone marker. And if so, that seems like a quite odd format String all in all (possibly producing output that is basically Wrong).

Other than that, output looks legit to me.

JooHyukKim · 2025-03-13T13:51:01Z

Filed #363, but super open for suggestions 😅

JooHyukKim · 2025-03-19T04:23:12Z

As per ChatGPT with reference, single quoted text Z is a string literal, meaning desererialization is expected to fail.

I think we can close this issue as working as expected

cristibozga · 2025-03-19T08:50:19Z

I just tested again the version 2.13.2 with
@jsonformat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd'T'HH:mm:ssX")
and I had no error.
So I guess we can close the ticket.
Thank you

cowtowncoder · 2025-03-19T16:44:38Z

Ok, closing. (2.13.2 is an ancient version fwtw).

cowtowncoder added a commit that referenced this issue Aug 15, 2024

Add failing test for #279

5220f92

cowtowncoder added has-failing-test Indicates that there exists a test case (under `failing/`) to reproduce the issue 2.18 labels Aug 15, 2024

cowtowncoder added a commit that referenced this issue Aug 15, 2024

Add failing test for #279 (#317)

a8776a6

cowtowncoder changed the title ~~OffsetDateTime deserializaion fails when using date-time pattern~~ OffsetDateTimedeserialization fails when using (specific?) date-time pattern Aug 15, 2024

JooHyukKim mentioned this issue Mar 19, 2025

Fix #279 OffsetDateTime deserialization fail with date-time pattern #363

Open

cowtowncoder closed this as completed Mar 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`OffsetDateTime`deserialization fails when using (specific?) date-time pattern #279

`OffsetDateTime`deserialization fails when using (specific?) date-time pattern #279

cristibozga commented Sep 1, 2023 •

edited by cowtowncoder

Loading

phoebe-lew commented Oct 3, 2023

jaymanik commented Jul 12, 2024 •

edited

Loading

cowtowncoder commented Jul 13, 2024

jaymanik commented Jul 16, 2024 •

edited

Loading

cowtowncoder commented Jul 17, 2024

jaymanik commented Jul 17, 2024

cristibozga commented Jul 24, 2024

cowtowncoder commented Jul 24, 2024

cowtowncoder commented Aug 15, 2024

JooHyukKim commented Mar 10, 2025

cowtowncoder commented Mar 10, 2025

JooHyukKim commented Mar 12, 2025 •

edited

Loading

cowtowncoder commented Mar 12, 2025

JooHyukKim commented Mar 12, 2025 •

edited

Loading

cowtowncoder commented Mar 13, 2025

JooHyukKim commented Mar 13, 2025

JooHyukKim commented Mar 19, 2025

cristibozga commented Mar 19, 2025

cowtowncoder commented Mar 19, 2025

OffsetDateTimedeserialization fails when using (specific?) date-time pattern #279

OffsetDateTimedeserialization fails when using (specific?) date-time pattern #279

Comments

cristibozga commented Sep 1, 2023 • edited by cowtowncoder Loading

phoebe-lew commented Oct 3, 2023

jaymanik commented Jul 12, 2024 • edited Loading

cowtowncoder commented Jul 13, 2024

jaymanik commented Jul 16, 2024 • edited Loading

cowtowncoder commented Jul 17, 2024

jaymanik commented Jul 17, 2024

cristibozga commented Jul 24, 2024

cowtowncoder commented Jul 24, 2024

cowtowncoder commented Aug 15, 2024

JooHyukKim commented Mar 10, 2025

cowtowncoder commented Mar 10, 2025

JooHyukKim commented Mar 12, 2025 • edited Loading

cowtowncoder commented Mar 12, 2025

JooHyukKim commented Mar 12, 2025 • edited Loading

cowtowncoder commented Mar 13, 2025

JooHyukKim commented Mar 13, 2025

JooHyukKim commented Mar 19, 2025

cristibozga commented Mar 19, 2025

cowtowncoder commented Mar 19, 2025

`OffsetDateTime`deserialization fails when using (specific?) date-time pattern #279

`OffsetDateTime`deserialization fails when using (specific?) date-time pattern #279

cristibozga commented Sep 1, 2023 •

edited by cowtowncoder

Loading

jaymanik commented Jul 12, 2024 •

edited

Loading

jaymanik commented Jul 16, 2024 •

edited

Loading

JooHyukKim commented Mar 12, 2025 •

edited

Loading

JooHyukKim commented Mar 12, 2025 •

edited

Loading