From 1fc0d95b3e2e7081531224299eeaca726bd7b78f Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 25 Jun 2020 14:30:55 -0700 Subject: [PATCH 1/6] make something great --- packages/app/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app/index.ts b/packages/app/index.ts index f6a32c844bb..c9a253808f1 100644 --- a/packages/app/index.ts +++ b/packages/app/index.ts @@ -21,7 +21,7 @@ import { isNode, isBrowser } from '@firebase/util'; import { logger } from './src/logger'; import { registerCoreComponents } from './src/registerCoreComponents'; -// Firebase Lite detection test +// Firebase Lite detection test make it great // eslint-disable-next-line @typescript-eslint/no-explicit-any if (isBrowser() && (self as any).firebase !== undefined) { logger.warn(` From af017ee186d08dee53cb537bb660946b62b045ac Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 25 Jun 2020 14:33:58 -0700 Subject: [PATCH 2/6] show branches --- .github/workflows/changesets.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/changesets.yml b/.github/workflows/changesets.yml index 3850cb83b4e..d61a13443c4 100644 --- a/.github/workflows/changesets.yml +++ b/.github/workflows/changesets.yml @@ -15,6 +15,9 @@ jobs: with: ## fetch all history for all branches and tags, so we can compare with master fetch-depth: 0 + + - name: Show branches + run: git branch - name: Setup Node.js 12.x uses: actions/setup-node@master @@ -23,6 +26,6 @@ jobs: - name: Install Dependencies run: yarn - + - name: Check if any Changeset file exists run: yarn changeset status --since=master \ No newline at end of file From cc7906c9b10c446ae90f467c1bb6e4612e519a9c Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 25 Jun 2020 14:58:11 -0700 Subject: [PATCH 3/6] use v2 --- .github/workflows/changesets.yml | 5 +---- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/changesets.yml b/.github/workflows/changesets.yml index d61a13443c4..0ebaa9a01ff 100644 --- a/.github/workflows/changesets.yml +++ b/.github/workflows/changesets.yml @@ -11,10 +11,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout Repo - uses: actions/checkout@master - with: - ## fetch all history for all branches and tags, so we can compare with master - fetch-depth: 0 + uses: actions/checkout@v2 - name: Show branches run: git branch diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9620aaab3e2..215410243d4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout Repo - uses: actions/checkout@master + uses: actions/checkout@v2 with: # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits fetch-depth: 0 From c99efd69ecad693b22450247c253b40ffe84a133 Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 25 Jun 2020 15:01:50 -0700 Subject: [PATCH 4/6] set depth to 0 --- .github/workflows/changesets.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/changesets.yml b/.github/workflows/changesets.yml index 0ebaa9a01ff..562ea7a7ab5 100644 --- a/.github/workflows/changesets.yml +++ b/.github/workflows/changesets.yml @@ -12,6 +12,9 @@ jobs: steps: - name: Checkout Repo uses: actions/checkout@v2 + with: + ## fetch all history for all branches and tags, so we can compare with master + fetch-depth: 0 - name: Show branches run: git branch From 3e5d06e2f75d72cbe2994b19508a736453afbf87 Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 25 Jun 2020 15:07:14 -0700 Subject: [PATCH 5/6] compare with origin master --- .github/workflows/changesets.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/changesets.yml b/.github/workflows/changesets.yml index 562ea7a7ab5..7da15d6fec5 100644 --- a/.github/workflows/changesets.yml +++ b/.github/workflows/changesets.yml @@ -12,9 +12,6 @@ jobs: steps: - name: Checkout Repo uses: actions/checkout@v2 - with: - ## fetch all history for all branches and tags, so we can compare with master - fetch-depth: 0 - name: Show branches run: git branch @@ -28,4 +25,4 @@ jobs: run: yarn - name: Check if any Changeset file exists - run: yarn changeset status --since=master \ No newline at end of file + run: yarn changeset status --since=origin/master \ No newline at end of file From 4e300707adb7b45c995d1f1bd742d98c4a4aeac7 Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 25 Jun 2020 15:11:31 -0700 Subject: [PATCH 6/6] test --- .github/workflows/changesets.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/changesets.yml b/.github/workflows/changesets.yml index 7da15d6fec5..7f3ebb7217a 100644 --- a/.github/workflows/changesets.yml +++ b/.github/workflows/changesets.yml @@ -12,6 +12,9 @@ jobs: steps: - name: Checkout Repo uses: actions/checkout@v2 + with: + ## fetch all history for all branches and tags, so we can compare with master + fetch-depth: 0 - name: Show branches run: git branch