fix: ensure all usages of markdown leaves check whether view is deferred

Author: Fevol

src/editor/renderers/post-process/util.ts

@@ -4,20 +4,22 @@ import type {BlockInfo} from "@codemirror/view";
 
 export function codeBlockPostProcessorUpdate(app: App, language: string) {
 	for (const leaf of app.workspace.getLeavesOfType("markdown")) {
-		const view = <MarkdownView> leaf.view;
-		if (view.editor.cm) {
-			const widgets = view.editor.cm.viewportLineBlocks.filter((block: BlockInfo) =>
-				block.widget && block.widget.lang === language
-			);
-			const original_selection = view.editor.cm.state.selection;
-			view.editor.cm.dispatch({
-				selection: EditorSelection.create(widgets.map((block: BlockInfo) => EditorSelection.range(block.from, block.to))),
-				scrollIntoView: false,
-			});
-			view.editor.cm.dispatch({
-				selection: original_selection,
-				scrollIntoView: false,
-			});
+		if (leaf.view instanceof MarkdownView) {
+			const { view } = leaf;
+			if (view.editor.cm) {
+				const widgets = view.editor.cm.viewportLineBlocks.filter((block: BlockInfo) =>
+					block.widget && block.widget.lang === language
+				);
+				const original_selection = view.editor.cm.state.selection;
+				view.editor.cm.dispatch({
+					selection: EditorSelection.create(widgets.map((block: BlockInfo) => EditorSelection.range(block.from, block.to))),
+					scrollIntoView: false,
+				});
+				view.editor.cm.dispatch({
+					selection: original_selection,
+					scrollIntoView: false,
+				});
+			}
 		}
 	}
 }
@@ -39,5 +41,7 @@ export function postProcessorUpdate(app: App) {
 
 export function postProcessorRerender(app: App) {
 	for (const leaf of app.workspace.getLeavesOfType("markdown"))
-		(leaf.view as MarkdownView).previewMode.rerender(true);
+		if (leaf.view instanceof MarkdownView) {
+			leaf.view.previewMode.rerender(true);
+		}
 }

src/editor/view-header/header-button.ts

@@ -33,7 +33,9 @@ export class HeaderButton {
 		this.has_label = render;
 
 		for (const leaf of this.plugin.app.workspace.getLeavesOfType("markdown")) {
-			const view = leaf.view as MarkdownView;
+			if (!(leaf.view instanceof MarkdownView)) continue;
+			const { view } = leaf;
+
 			const { text } = this.states[this.getvalue(view)];
 			const elements = this.active_mapping.get(view);
 			if (!elements) continue;
@@ -72,9 +74,8 @@ export class HeaderButton {
 			this.changeEvent = this.plugin.app.workspace.on("layout-change", this.attachButtons.bind(this));
 
 		for (const leaf of this.plugin.app.workspace.getLeavesOfType("markdown")) {
-			// Check if the view is deferred
-			let { view } = leaf;
-			if (!(view instanceof MarkdownView)) continue;
+			if (!(leaf.view instanceof MarkdownView)) continue;
+			const { view } = leaf;
 
 			if (this.active_mapping.has(view)) continue;
 			const event = leaf.on("history-change", () => {
@@ -137,8 +138,10 @@ export class HeaderButton {
 	detachButtons() {
 		if (!this.changeEvent) return;
 
-		for (const leaf of this.plugin.app.workspace.getLeavesOfType("markdown"))
+		for (const leaf of this.plugin.app.workspace.getLeavesOfType("markdown")) {
+			if (!(leaf.view instanceof MarkdownView)) continue;
 			this.detachButton(leaf);
+		}
 		this.plugin.app.workspace.offref(this.changeEvent!);
 		this.changeEvent = null;
 	}

src/ui/pages/view/ViewPage.svelte

@@ -566,6 +566,8 @@
 
                 const file = plugin.app.vault.getAbstractFileByPath(row.path);
                 if (!file) return;
+
+                await plugin.app.workspace.revealLeaf(lastActiveLeaf);
                 const view = lastActiveLeaf.view;
 
                 if (file !== view.file) await lastActiveLeaf.openFile(file);