Skip to content

Commit 019a20b

Browse files
committed
chore: address review feedback
Throw an error if `firebase.json` is missing. Print a neutral tracking log after processing GAC info
1 parent 928e9b7 commit 019a20b

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/index.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,12 @@ async function run() {
6565
if (existsSync("./firebase.json")) {
6666
console.log("firebase.json file found. Continuing deploy.");
6767
} else {
68-
console.warn(
68+
throw Error(
6969
"firebase.json file not found. If your firebase.json file is not in the root of your repo, edit the entryPoint option of this GitHub action."
7070
);
7171
}
7272
const gacFilename = await createGacFile(googleApplicationCredentials);
73-
if (gacFilename !== googleApplicationCredentials) {
74-
console.log(
75-
"Created a temporary file with Google Application Credentials."
76-
);
77-
}
73+
console.log("Google Application Credentials acquired.");
7874
endGroup();
7975

8076
if (configuredChannelId === "live") {

0 commit comments

Comments
 (0)