From 1edc579f481b2a0037901bf96c7a20c4b8b579af Mon Sep 17 00:00:00 2001 From: kyle-ssg Date: Fri, 28 Mar 2025 11:20:58 +0000 Subject: [PATCH 1/4] Prevent identity fetch when traits and identity are undefined --- package.json | 4 ++-- src/commands/get/index.ts | 20 ++++++++++++++++---- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 46fcd42..e8f9143 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "flagsmith-cli", - "version": "0.2.1", + "version": "0.2.2", "description": "A CLI allowing you to fetch Flagsmith flags and output them to a file", "author": "kyle-ssg @kyle-ssg", "bin": { @@ -39,7 +39,7 @@ "shx": "^0.3.3", "ts-node": "^10.2.1", "tslib": "^2.3.1", - "typescript": "4.4.4" + "typescript": "5.8.2" }, "oclif": { "bin": "flagsmith", diff --git a/src/commands/get/index.ts b/src/commands/get/index.ts index f0938ca..2f306a8 100644 --- a/src/commands/get/index.ts +++ b/src/commands/get/index.ts @@ -72,12 +72,17 @@ export default class FlagsmithGet extends Command { outputString += ` for identity ${identity}` } - const traits : Record = {} - for (const t of flags.trait || []) { - const [k, v] = t.split(/=(.*)/s) - traits[k] = v + let traits : Record | undefined = undefined + + if(flags.trait) { + traits = {} + for (const t of flags.trait || []) { + const [k, v] = t.split(/=(.*)/s) + traits[k] = v + } } + const output = flags.output const entity = flags.entity const isDocument = entity === 'environment' @@ -103,6 +108,13 @@ export default class FlagsmithGet extends Command { } }) } else { + console.log("INIT", { + environmentID: environment, + fetch: fetch, + api: api, + identity: identity, + traits: traits, + }) await flagsmith.init({ environmentID: environment, fetch: fetch, From 3d303d96376e8ff1f59a51622dc6f3cbda9b0443 Mon Sep 17 00:00:00 2001 From: kyle-ssg Date: Fri, 28 Mar 2025 11:24:21 +0000 Subject: [PATCH 2/4] Revert typescript package upgrade --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e8f9143..9b2f669 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "shx": "^0.3.3", "ts-node": "^10.2.1", "tslib": "^2.3.1", - "typescript": "5.8.2" + "typescript": "4.4.4" }, "oclif": { "bin": "flagsmith", From 5967ee08af4c9108e6822f188557d120ede58815 Mon Sep 17 00:00:00 2001 From: kyle-ssg Date: Fri, 28 Mar 2025 11:25:00 +0000 Subject: [PATCH 3/4] Revert comment --- src/commands/get/index.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/commands/get/index.ts b/src/commands/get/index.ts index 2f306a8..1a819b1 100644 --- a/src/commands/get/index.ts +++ b/src/commands/get/index.ts @@ -108,13 +108,6 @@ export default class FlagsmithGet extends Command { } }) } else { - console.log("INIT", { - environmentID: environment, - fetch: fetch, - api: api, - identity: identity, - traits: traits, - }) await flagsmith.init({ environmentID: environment, fetch: fetch, From 41a23abd173ac6aa4a4e812dfb06b083b418d493 Mon Sep 17 00:00:00 2001 From: kyle-ssg Date: Fri, 28 Mar 2025 11:25:22 +0000 Subject: [PATCH 4/4] Revert line break --- src/commands/get/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/commands/get/index.ts b/src/commands/get/index.ts index 1a819b1..7e491a9 100644 --- a/src/commands/get/index.ts +++ b/src/commands/get/index.ts @@ -82,7 +82,6 @@ export default class FlagsmithGet extends Command { } } - const output = flags.output const entity = flags.entity const isDocument = entity === 'environment'