feat(Client): Add mapper layer for context-based engine #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Zaimwa9
requested changes
Nov 20, 2025
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Couple of NITs, one is blocking (environment.name). Thanks for the exhaustive test, unfortunately i'm unable to provide code improvements
Co-authored-by: Claude <[email protected]>
khvn26
previously approved these changes
Nov 25, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
LGTM overall, with optional test-related nitpicks 👍
emyller
force-pushed
the
feat/client/map-envdoc-to-new-engine
branch
from
c731708 to
6beff14
Compare
khvn26
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mapper layer to transform environment documents into evaluation contexts. No SDK integration in this PR.
This is pass 2 of 3.
GetEvaluationResult#171)Mapper implementation inspired by:
Changes
Contributes to #168
Review effort: 4/5