Skip to content

Commit 29c7613

Browse files
authored
fix: removed-dango-id-usage-in-mapper (#229)
1 parent 3c1d200 commit 29c7613

File tree

3 files changed

+1
-51
lines changed

3 files changed

+1
-51
lines changed

flagsmith-engine/evaluation/evaluationContext/mappers.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,6 @@ function mapIdentityModelToIdentityContext(
127127
traits: traitsContext
128128
};
129129

130-
if (identity.djangoID !== undefined) {
131-
identityContext.key = identity.djangoID.toString();
132-
}
133-
134130
return identityContext;
135131
}
136132

tests/engine/unit/mappers.test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,7 @@ describe('getEvaluationContext', () => {
236236
[new TraitModel('email', '[email protected]'), new TraitModel('age', 25)],
237237
[],
238238
'B62qaMZNwfiqT76p38ggrQ',
239-
'test_user',
240-
undefined,
241-
123
239+
'test_user'
242240
);
243241

244242
// When
@@ -247,7 +245,6 @@ describe('getEvaluationContext', () => {
247245
// Then
248246
expect(context.identity).toBeDefined();
249247
expect(context.identity?.identifier).toBe('test_user');
250-
expect(context.identity?.key).toBe('123');
251248
expect(context.identity?.traits).toEqual({
252249
253250
age: 25

tests/engine/unit/segments/segment_evaluators.test.ts

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -82,49 +82,6 @@ test('test_traits_match_segment_condition_for_trait_existence_operators', () =>
8282
}
8383
});
8484

85-
test('getIdentitySegments uses django ID for hashed percentage when present', () => {
86-
var identityModel = new IdentityModel(
87-
Date.now().toString(),
88-
[],
89-
[],
90-
environment().apiKey,
91-
'identity_1',
92-
undefined,
93-
1
94-
);
95-
const segmentDefinition = {
96-
id: 1,
97-
name: 'percentage_split_segment',
98-
rules: [
99-
{
100-
type: ALL_RULE,
101-
conditions: [
102-
{
103-
operator: PERCENTAGE_SPLIT,
104-
property_: null,
105-
value: '10'
106-
}
107-
],
108-
rules: []
109-
}
110-
],
111-
feature_states: []
112-
};
113-
const segmentModel = buildSegmentModel(segmentDefinition);
114-
const environmentModel = environment();
115-
environmentModel.project.segments = [segmentModel];
116-
const context = getEvaluationContext(environmentModel, identityModel);
117-
118-
var result = getIdentitySegments(context);
119-
120-
expect(result).toHaveLength(1);
121-
expect(getHashedPercentageForObjIds).toHaveBeenCalledTimes(1);
122-
expect(getHashedPercentageForObjIds).toHaveBeenCalledWith([
123-
result[0].key,
124-
context.identity!.key
125-
]);
126-
});
127-
12885
describe('getIdentitySegments integration', () => {
12986
test('returns only matching segments', () => {
13087
const context: EvaluationContext = {

0 commit comments

Comments
 (0)