Skip to content

Commit 856e5fe

Browse files
committed
refactor: add check on update func and clean up comments
1 parent 3308c4e commit 856e5fe

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

frontend/web/components/pages/project-settings/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const ProjectSettingsPage = () => {
3030
const hasEnvironments = !!project?.environments?.length
3131
const hasFeatureHealth = Utils.getFlagsmithHasFeature('feature_health')
3232

33-
// Derive organisationId from project data
33+
// Derive organisationId from project data (not available in route params)
3434
const organisationId = project?.organisation
3535

3636
if (isLoading || !project || !projectId || !organisationId) {

frontend/web/components/pages/project-settings/tabs/CustomFieldsTab.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ type CustomFieldsTabProps = {
77
}
88

99
export const CustomFieldsTab = ({ organisationId }: CustomFieldsTabProps) => {
10-
// Runtime safety check
1110
if (!organisationId) {
1211
return (
1312
<div className='mt-4'>

frontend/web/components/pages/project-settings/tabs/GeneralTab/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export const GeneralTab = ({ project, projectId }: GeneralTabProps) => {
2121
const history = useHistory()
2222
const [updateProject, { isLoading: isSaving }] = useUpdateProjectMutation()
2323

24-
// Local form state
2524
const [name, setName] = useState(project.name)
2625
const [staleFlagsLimitDays, setStaleFlagsLimitDays] = useState(
2726
project.stale_flags_limit_days,

frontend/web/components/pages/project-settings/tabs/SDKSettingsTab.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,16 @@ import { useUpdateProjectMutation } from 'common/services/useProject'
66

77
type SDKSettingsTabProps = {
88
project: Project
9-
projectId: number
9+
projectId?: string | number
1010
environmentId?: string
11+
organisationId?: number
1112
}
1213

1314
export const SDKSettingsTab = ({ project, projectId }: SDKSettingsTabProps) => {
1415
const [updateProject, { isLoading: isSaving }] = useUpdateProjectMutation()
1516

1617
const handleRealtimeToggle = useCallback(async () => {
18+
if (!projectId) return
1719
await updateProject({
1820
body: {
1921
enable_realtime_updates: !project.enable_realtime_updates,
@@ -23,6 +25,7 @@ export const SDKSettingsTab = ({ project, projectId }: SDKSettingsTabProps) => {
2325
}, [project.enable_realtime_updates, projectId, updateProject])
2426

2527
const handleHideDisabledFlagsToggle = useCallback(async () => {
28+
if (!projectId) return
2629
await updateProject({
2730
body: {
2831
hide_disabled_flags: !project.hide_disabled_flags,

0 commit comments

Comments
 (0)