feat(experimentation): return feature object along with experiment entity (#7609)

Author: Zaimwa9

api/experimentation/serializers.py

@@ -10,6 +10,8 @@
 )
 from experimentation.types import SNOWFLAKE_DEFAULTS, SnowflakeConfig
 from features.feature_types import MULTIVARIATE
+from features.models import Feature
+from features.multivariate.serializers import NestedMultivariateFeatureOptionSerializer
 
 
 class WarehouseConnectionSerializer(serializers.ModelSerializer):  # type: ignore[type-arg]
@@ -115,3 +117,18 @@ def validate(self, attrs: dict[str, Any]) -> dict[str, Any]:
                 {"feature": "Cannot change the feature of an existing experiment."}
             )
         return attrs
+
+
+class ExperimentFeatureSerializer(serializers.ModelSerializer):  # type: ignore[type-arg]
+    multivariate_options = NestedMultivariateFeatureOptionSerializer(
+        many=True, read_only=True
+    )
+
+    class Meta:
+        model = Feature
+        fields = ("id", "name", "type", "initial_value", "multivariate_options")
+        read_only_fields = fields
+
+
+class ExperimentListSerializer(ExperimentSerializer):
+    feature = ExperimentFeatureSerializer(read_only=True)

api/experimentation/views.py

@@ -20,6 +20,7 @@
     WarehouseConnectionPermission,
 )
 from experimentation.serializers import (
+    ExperimentListSerializer,
     ExperimentSerializer,
     WarehouseConnectionSerializer,
 )
@@ -111,8 +112,17 @@ def get_serializer_context(self) -> dict[str, Any]:
         context["environment"] = self._get_environment()
         return context
 
+    def get_serializer_class(self) -> type[BaseSerializer[Experiment]]:
+        if self.action in ("list", "retrieve", "start", "pause", "complete"):
+            return ExperimentListSerializer
+        return ExperimentSerializer
+
     def get_queryset(self) -> "QuerySet[Experiment]":
         qs = super().get_queryset()
+        if self.action in ("list", "retrieve"):
+            qs = qs.select_related("feature").prefetch_related(
+                "feature__multivariate_options"
+            )
         status_filter = self.request.query_params.get("status")
         if status_filter:
             qs = qs.filter(status=status_filter)

api/tests/unit/experimentation/test_experiment_views.py

@@ -269,6 +269,53 @@ def test_get_list__with_experiments__returns_all(
     assert response.json()[0]["id"] == experiment.id
 
 
+def test_get_list__with_experiments__returns_nested_feature(
+    admin_client_new: APIClient,
+    environment: Environment,
+    experiment: Experiment,
+    multivariate_feature: Feature,
+    enable_features: EnableFeaturesFixture,
+) -> None:
+    # Given
+    enable_features(EXPERIMENT_FLAG)
+
+    # When
+    response = admin_client_new.get(_list_url(environment))
+
+    # Then
+    assert response.status_code == status.HTTP_200_OK
+    data = response.json()
+    assert len(data) == 1
+    feature_data = data[0]["feature"]
+    assert isinstance(feature_data, dict)
+    assert feature_data["id"] == multivariate_feature.id
+    assert feature_data["name"] == multivariate_feature.name
+    assert feature_data["type"] == "MULTIVARIATE"
+    assert feature_data["initial_value"] == "control"
+    assert len(feature_data["multivariate_options"]) == 3
+
+
+def test_get_detail__exists__returns_nested_feature(
+    admin_client_new: APIClient,
+    environment: Environment,
+    experiment: Experiment,
+    multivariate_feature: Feature,
+    enable_features: EnableFeaturesFixture,
+) -> None:
+    # Given
+    enable_features(EXPERIMENT_FLAG)
+
+    # When
+    response = admin_client_new.get(_detail_url(environment, experiment))
+
+    # Then
+    assert response.status_code == status.HTTP_200_OK
+    feature_data = response.json()["feature"]
+    assert isinstance(feature_data, dict)
+    assert feature_data["id"] == multivariate_feature.id
+    assert feature_data["name"] == multivariate_feature.name
+
+
 def test_get_list__empty__returns_200(
     admin_client_new: APIClient,
     environment: Environment,