TASK: Catch error because of legacy internal property names

Author: mhsdesign

Classes/Domain/NodeCreation/PropertiesAndReferences.php

@@ -53,10 +53,9 @@ public static function createFromArrayAndTypeDeclarations(array $propertiesAndRe
     public function requireValidProperties(NodeType $nodeType, CaughtExceptions $caughtExceptions): array
     {
         $validProperties = [];
-        $defaultValues = $nodeType->getDefaultValuesForProperties();
         foreach ($this->properties as $propertyName => $propertyValue) {
-            $this->assertValidPropertyName($propertyName);
             try {
+                $this->assertValidPropertyName($propertyName);
                 if (!isset($nodeType->getProperties()[$propertyName])) {
                     throw new PropertyIgnoredException(
                         sprintf(
@@ -109,20 +108,20 @@ public function requireValidReferences(NodeType $nodeType, Context $subgraph, Ca
 
     /**
      * In the old CR, it was common practice to set internal or meta properties via this syntax: `_hidden` but we don't allow this anymore.
-     * @throws \InvalidArgumentException
+     * @throws PropertyIgnoredException
      */
     private function assertValidPropertyName($propertyName): void
     {
         $legacyInternalProperties = ['_accessRoles', '_contentObject', '_hidden', '_hiddenAfterDateTime', '_hiddenBeforeDateTime', '_hiddenInIndex',
             '_index', '_name', '_nodeType', '_removed', '_workspace'];
         if (!is_string($propertyName) || $propertyName === '') {
-            throw new \InvalidArgumentException(sprintf('Property name must be a non empty string. Got "%s".', $propertyName));
+            throw new PropertyIgnoredException(sprintf('Because property name must be a non empty string. Got "%s".', $propertyName), 1686149518395);
         }
         if ($propertyName[0] === '_') {
             $lowerPropertyName = strtolower($propertyName);
             foreach ($legacyInternalProperties as $legacyInternalProperty) {
                 if ($lowerPropertyName === strtolower($legacyInternalProperty)) {
-                    throw new \InvalidArgumentException(sprintf('Internal legacy property "%s" not implement.', $propertyName));
+                    throw new PropertyIgnoredException(sprintf('Because internal legacy property "%s" not implement.', $propertyName), 1686149513158);
                 }
             }
         }

Configuration/Testing/NodeTypes.Malformed.yaml

@@ -33,6 +33,9 @@
     template:
       properties:
         foo: "${cannotCallThis()}"
+        # legacy properties fail
+        _hidden: true
+        _hiddenAfterDateTime: 123
         boolValue: 123
         stringValue: false
         reference: "non-existing-node-id"

Tests/Functional/Fixtures/WithEvaluationExceptions.messages.json

@@ -43,6 +43,14 @@
         "message": "Configuration \"null\" in \"childNodes.withItemsAbortBecauseNotIterable.withItems\" | RuntimeException(Type NULL is not iterable., 1685802354186)",
         "severity": "ERROR"
     },
+    {
+        "message": "Property \"_hidden\" in NodeType \"Flowpack.NodeTemplates:Content.WithEvaluationExceptions\" | PropertyIgnoredException(Because internal legacy property \"_hidden\" not implement., 1686149513158)",
+        "severity": "ERROR"
+    },
+    {
+        "message": "Property \"_hiddenAfterDateTime\" in NodeType \"Flowpack.NodeTemplates:Content.WithEvaluationExceptions\" | PropertyIgnoredException(Because internal legacy property \"_hiddenAfterDateTime\" not implement., 1686149513158)",
+        "severity": "ERROR"
+    },
     {
         "message": "Property \"boolValue\" in NodeType \"Flowpack.NodeTemplates:Content.WithEvaluationExceptions\" | PropertyIgnoredException(Because value `123` is not assignable to property type \"boolean\"., 1685958105644)",
         "severity": "ERROR"

Tests/Functional/Fixtures/WithEvaluationExceptions.template.json

@@ -1,5 +1,7 @@
 {
     "properties": {
+        "_hidden": true,
+        "_hiddenAfterDateTime": 123,
         "boolValue": 123,
         "stringValue": false,
         "reference": "non-existing-node-id",