Merge pull request #4 from daniellienert/master

Christian Müller · Christian Müller · commit 3c86a3c4a466 · 2015-03-31T20:23:30.000+02:00
[BUGFIX] Do not quote the prepared statement arguments.
diff --git a/Classes/Flowpack/SimpleSearch/Domain/Service/SqLiteIndex.php b/Classes/Flowpack/SimpleSearch/Domain/Service/SqLiteIndex.php
@@ -86,7 +86,7 @@ public function insertOrUpdatePropertiesToIndex($properties, $identifier) {
 		$statementArgumentNumber = 1;
 		foreach ($properties as $propertyName => $propertyValue) {
 			$propertyColumnNamesString .= '"' . $propertyName . '", ';
-			$valueNamesString .= '"' . $this->preparedStatementArgumentName($statementArgumentNumber) . '", ';
+			$valueNamesString .= $this->preparedStatementArgumentName($statementArgumentNumber) . ', ';
 			$statementArgumentNumber++;
 		}
 		$propertyColumnNamesString = trim($propertyColumnNamesString);
@@ -240,4 +240,4 @@ protected function adjustIndexToGivenProperties(array $propertyNames) {
 			}
 		}
 	}
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public function insertOrUpdatePropertiesToIndex($properties, $identifier) {`
`86`	`86`	`$statementArgumentNumber = 1;`
`87`	`87`	`foreach ($properties as $propertyName => $propertyValue) {`
`88`	`88`	`$propertyColumnNamesString .= '"' . $propertyName . '", ';`
`89`		`- $valueNamesString .= '"' . $this->preparedStatementArgumentName($statementArgumentNumber) . '", ';`
	`89`	`+ $valueNamesString .= $this->preparedStatementArgumentName($statementArgumentNumber) . ', ';`
`90`	`90`	`$statementArgumentNumber++;`
`91`	`91`	`}`
`92`	`92`	`$propertyColumnNamesString = trim($propertyColumnNamesString);`
`@@ -240,4 +240,4 @@ protected function adjustIndexToGivenProperties(array $propertyNames) {`
`240`	`240`	`}`
`241`	`241`	`}`
`242`	`242`	`}`
`243`		`-}`
	`243`	`+}`