Address some remaining c-style casts

Author: knoepfel

form/root_storage/root_rfield_read_container.cpp

@@ -79,8 +79,9 @@ namespace form::detail::experimental {
       createView(type);
     }
 
-    if (id >= (int)m_reader->GetNEntries())
+    if (id >= static_cast<int>(m_reader->GetNEntries())) {
       return false;
+    }
 
     //Using RNTupleView<> to read instead of reusing REntry gives us full schema evolution support: the ROOT feature that lets us read files with an old class version into a new class version's memory.
     auto buffer = m_view->GetField().CreateObject<void>(); //PHLEX gets ownership of this memory

form/storage/storage_reader.cpp

@@ -147,8 +147,7 @@ namespace {
     if (components.empty()) {
       return false;
     }
-    for (auto const& [key, value] : components) {
-      (void)key;
+    for (auto const& [_, value] : components) {
       if (value != 0) {
         return false;
       }
@@ -356,8 +355,7 @@ std::vector<std::string> StorageReader::listIndices(
 
   std::vector<std::string> result;
   result.reserve(ordered.size());
-  for (auto const& [entry, index_string] : ordered) {
-    (void)entry;
+  for (auto const& [_, index_string] : ordered) {
     result.push_back(index_string);
   }
   return result;

phlex/model/index_generator.hpp

@@ -79,7 +79,7 @@ namespace phlex {
         return *this;
       }
 
-      void operator++(int) { (void)++(*this); }
+      void operator++(int) { ++(*this); }
 
       value_type const& operator*() const noexcept { return coroutine_.promise().current_; }
       value_type const* operator->() const noexcept

plugins/python/src/configwrap.cpp

@@ -98,7 +98,7 @@ static PyObject* pcm_subscript(py_config_map* pycmap, PyObject* pykey)
         pyvalue = PyTuple_New(*cvalue_size);
         // We can use std::views::enumerate once the AppleClang C++ STL supports it.
         for (Py_ssize_t i = 0; i < *cvalue_size; ++i) {
-          PyObject* item = PyLong_FromLong((long)cvalue[i]);
+          PyObject* item = PyLong_FromLong(static_cast<long>(cvalue[i]));
           PyTuple_SetItem(pyvalue, i, item);
         }
       } else if (k.first == boost::json::kind::int64) {

plugins/python/src/dyncall.cpp

@@ -110,7 +110,7 @@ void phlex::experimental::dyncall(void* fn, dcarg& result, dcargs_t& args, int v
   // because libffi is, and that yields a plethora of warnings from clang-tidy,
   // none of which warrant actual changes.
   // NOLINTBEGIN
-  std::size_t nargs = (std::size_t)args.size();
+  std::size_t nargs = args.size();
 
   auto t = std::make_unique<ffi_type*[]>(nargs);
   auto p = std::make_unique<void*[]>(nargs);

plugins/python/src/modulewrap.cpp

@@ -177,7 +177,7 @@ namespace {
       PyGILRAII gil;
 
       dcarg result{nullptr};
-      dyncall((void*)m_ccallback, result, argsv, 1);
+      dyncall(m_ccallback, result, argsv, 1);
 
       std::string error_msg;
       if (!result.get<PyObject*>()) {
@@ -227,7 +227,7 @@ namespace {
       argsv.reserve(sizeof...(Is));
       (argsv.push_back(args), ...);
 
-      dyncall((void*)m_ccallback, result, argsv);
+      dyncall(m_ccallback, result, argsv);
       // TODO: error reporting?
 
       if constexpr (!std::is_void_v<RT>) {

plugins/python/src/pymodule.cpp

@@ -210,7 +210,7 @@ static bool initialize()
   // Python interpreter will not happen atm.
   static std::atomic<bool> gil_released{false};
   if (!gil_released.exchange(true)) {
-    (void)PyEval_SaveThread(); // state not saved, as no place to restore
+    PyEval_SaveThread(); // state not saved, as no place to restore
   }
 
   return true;

test/form/form_source_extra_types.cpp

@@ -1,6 +1,8 @@
 #include "form/form_source_type_registry.hpp"
 #include "phlex/module.hpp"
 
+#include <utility>
+
 using namespace phlex;
 
 namespace {
@@ -23,9 +25,8 @@ namespace {
   }
 }
 
-PHLEX_REGISTER_ALGORITHMS(m, config)
+PHLEX_REGISTER_ALGORITHMS(m)
 {
-  (void)m;
-  (void)config;
+  std::ignore = m;
   register_extra_form_types_once();
 }