wip

Signed-off-by: Daniel Schaefer <[email protected]>

Author: JohnAZoidberg

framework_lib/src/chromium_ec/mod.rs

@@ -566,7 +566,7 @@ impl CrosEc {
     /// Check for success and returns Err if not successful
     pub fn retimer_enable_fwupd(&self, retimer: u8, enable: bool) -> EcResult<()> {
         if self.retimer_in_fwupd_mode(retimer)? == enable {
-            info!("Retimer update mode already: {:?}", enable);
+            error!("Retimer update mode already: {:?}", enable);
             return Ok(());
         }
         EcRequestRetimerControl {
@@ -579,6 +579,8 @@ impl CrosEc {
         }
         .send_command(self)?;
 
+        os_specific::sleep(1000_000);
+        error!("Failed to set retimer update mode to: {}", enable);
         if self.retimer_in_fwupd_mode(retimer)? != enable {
             return Err(EcError::DeviceError(format!(
                 "Failed to set retimer update mode to: {}",

framework_lib/src/commandline/mod.rs

@@ -1639,7 +1639,7 @@ fn selftest(ec: &CrosEc) -> Option<()> {
 //   - Parade Retimer on both back ports (with firmware)
 fn selftest_retimer(ec: &CrosEc) -> EcResult<()> {
     // TODO: Make sure that it can work for the NVIDIA dGPU retimer and increase to 3
-    for i in 0..2 {
+    for i in 1..2 {
         let update_mode = ec.retimer_in_fwupd_mode(i);
         if update_mode == Err(EcError::Response(EcResponseStatus::InvalidParameter)) {
             println!("  Retimer status not supported on this platform. Cannot test");
@@ -1648,15 +1648,21 @@ fn selftest_retimer(ec: &CrosEc) -> EcResult<()> {
         println!("  Retimers on PD Controller {}", i);
         println!("    In update mode: {:?}", update_mode);
         if update_mode? {
-            println!("    Unexpected! During normal operaton it should not be in update mode! Disabling...");
+            println!("      Disabling it to start test.");
             ec.retimer_enable_fwupd(i, false)?;
+            os_specific::sleep(100);
         }
+
         println!("    Enabling update mode");
         let success = ec.retimer_enable_fwupd(i, true);
-        println!("    Success: {:?}", success);
+        os_specific::sleep(100);
+        //println!("    Result:  {:?}", success);
+        println!("    In update mode: {:?}", ec.retimer_in_fwupd_mode(i).unwrap());
 
         println!("    Disabling again");
         ec.retimer_enable_fwupd(i, false)?;
+        os_specific::sleep(100);
+        println!("    In update mode: {:?}", ec.retimer_in_fwupd_mode(i).unwrap());
         success?;
     }
     Ok(())