fix: resolve 48 ESLint warnings (unused vars, dead code, stray any casts)

Author: DreadKnight

.eslintrc.json

@@ -7,7 +7,8 @@
 		{
 			"files": ["**/__tests__/**/*.ts", "**/*.test.ts", "**/*.spec.ts"],
 			"rules": {
-				"@typescript-eslint/no-explicit-any": "off"
+				"@typescript-eslint/no-explicit-any": "off",
+				"@typescript-eslint/no-empty-function": "off"
 			}
 		}
 	],

src/__tests__/multiplayer/DevvitQueue.test.ts

@@ -1,4 +1,4 @@
-import { jest, expect, describe, test, beforeEach } from '@jest/globals';
+import { expect, describe, test, beforeEach } from '@jest/globals';
 import {
 	handleQueueJoin,
 	handleQueueStatus,

src/creature.ts

@@ -13,12 +13,7 @@ import { AugmentedMatrix } from './utility/matrices';
 import { Trap } from './utility/trap';
 import { HEX_WIDTH_PX, hashOffsetCoords, offsetNeighbors } from './utility/const';
 import { CreatureType, Level, Realm, Unit, UnitName } from './data/types';
-import {
-	PlasmaField,
-	detectWeakHardware,
-	detectVeryWeakHardware,
-	computePlasmaRenderScale,
-} from './plasma-field';
+import { PlasmaField, detectWeakHardware, detectVeryWeakHardware } from './plasma-field';
 
 /** Vertical distance (in pixels) between the Dark Priest's feet and the Plasma Field center. */
 const PLASMA_FIELD_OFFSET_Y = 90;

src/devvit/headlessGame.ts

@@ -354,29 +354,6 @@ class SimSignal {
 	}
 }
 
-// ─── jQuery mock (chainable no-op) ───────────────────────────────────────────
-
-function makeJQueryChain(): any {
-	const chain: any = new Proxy(
-		function _jq() {
-			return chain;
-		},
-		{
-			get(_target, prop) {
-				if (prop === 'then' || prop === Symbol.toPrimitive) return undefined;
-				if (prop === 'length') return 0;
-				if (prop === 'width' || prop === 'height') return () => 1920;
-				if (prop === 'offset') return () => ({ top: 0, left: 0 });
-				return () => chain;
-			},
-			apply() {
-				return chain;
-			},
-		},
-	);
-	return chain;
-}
-
 // ─── Animations mock (completes movement synchronously) ─────────────────────
 
 class MockAnimations {

src/game.ts

@@ -25,7 +25,8 @@ import type {
 	LobbyState,
 } from './multiplayer';
 import type { AuthoritativeState, Intent } from './multiplayer/authoritative';
-import { getVisibilityAwareDelay, sleep } from './utility/time';
+import type { AbilityTarget } from './multiplayer/types';
+import { getVisibilityAwareDelay } from './utility/time';
 import { DEBUG_DISABLE_GAME_STATUS_CONSOLE_LOG, DEBUG_DISABLE_MUSIC } from './debug';
 import { Point, configure as configurePointFacade } from './utility/pointfacade';
 import { pretty as version } from './utility/version';
@@ -925,10 +926,10 @@ export default class Game {
 			const intent = message.intent;
 			switch (intent.kind) {
 				case 'skip':
-					this.action({ action: 'skip' }, { callback() {} });
+					this.action({ action: 'skip' }, {});
 					break;
 				case 'delay':
-					this.action({ action: 'delay' }, { callback() {} });
+					this.action({ action: 'delay' }, {});
 					break;
 				case 'move':
 					this.action(
@@ -942,8 +943,13 @@ export default class Game {
 					break;
 				case 'ability':
 					this.action(
-						{ action: 'ability', id: intent.id, target: intent.target, args: intent.args },
-						{ callback() {} },
+						{
+							action: 'ability',
+							id: intent.id,
+							target: intent.target,
+							args: intent.args,
+						},
+						{},
 					);
 					break;
 			}
@@ -1100,17 +1106,7 @@ export default class Game {
 		});
 	}
 
-	sendMultiplayerAbility(params: {
-		target: {
-			type: string;
-			x?: number;
-			y?: number;
-			crea?: number;
-			array?: Array<{ x: number; y: number }>;
-		};
-		id: number;
-		args: unknown[];
-	}): void {
+	sendMultiplayerAbility(params: { target: AbilityTarget; id: number; args: unknown[] }): void {
 		if (!this.multiplayer || !this.lobby || !this.activeCreature) {
 			return;
 		}
@@ -1124,15 +1120,15 @@ export default class Game {
 			this.sendIntent({
 				kind: 'ability',
 				id: params.id,
-				target: params.target as any,
+				target: params.target,
 				args: params.args,
 			} as Intent);
 			return;
 		}
 		this.lobby.sendAction({
 			type: 'action-ability',
 			id: params.id,
-			target: params.target as any, // eslint-disable-line @typescript-eslint/no-explicit-any
+			target: params.target,
 			args: params.args,
 			playerId: this.lobby.getLocalPlayer()?.playerId || '',
 			creatureId: this.activeCreature.id,
@@ -1159,7 +1155,7 @@ export default class Game {
 		// which are stricter than the serializable snapshot. Cast to `any` so the
 		// authoritative state can drive the live game without fighting internal
 		// types; the fields we set are the canonical ones `serializeState` reads.
-		const g = this as any;
+		const g = this as any; // eslint-disable-line @typescript-eslint/no-explicit-any
 		for (const snap of state.creatures) {
 			const creature = g.creatures[snap.id];
 			if (!creature) {