+[{"id":4324047091,"node_id":"PRR_kwDOCeJETc8AAAABAbu48w","user":{"login":"copilot-pull-request-reviewer[bot]","id":175728472,"node_id":"BOT_kgDOCnlnWA","avatar_url":"https://avatars.githubusercontent.com/in/946600?v=4","gravatar_id":"","url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D","html_url":"https://github.com/apps/copilot-pull-request-reviewer","followers_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/followers","following_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/repos","events_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/received_events","type":"Bot","user_view_type":"public","site_admin":false},"body":"## Pull request overview\n\nThis PR addresses issue #171 by preventing disabled `for_*` plugins from being loaded/initialized via `external_plugins`, and it refactors the build pipeline/docs so custom plugins are no longer mirrored into the upstream TinyMCE vendor tree.\n\n**Changes:**\n- Filter `external_plugins` at runtime to only include plugins enabled in the profile’s `plugins:` list (fixes #171).\n- Update build/sync/clean scripts + plugin workspace `build-copy` scripts to stop writing custom plugins into `assets/vendor/tinymce/plugins/` and clean historical leftovers.\n- Refactor parts of `for_images` (clipboard/delete helpers, DOM traversal) and change the “swap from mediapool” button to delegate to TinyMCE’s image dialog.\n\n### Reviewed changes\n\nCopilot reviewed 33 out of 99 changed files in this pull request and generated 3 comments.\n\n<details>\n<summary>Show a summary per file</summary>\n\n| File | Description |\r\n| ---- | ----------- |\r\n| scripts/sync-build-to-assets.js | Document and enforce syncing staged build output into `assets/` without mirroring custom plugins into vendor. |\r\n| scripts/clean-build.js | Remove `build/` and delete stray custom plugin folders from `assets/vendor/tinymce/plugins/`. |\r\n| scripts/build-plugins.js | Refactor custom-plugin build pipeline; staging output support; stop writing into vendor tree. |\r\n| package.yml | Bump addon version to 8.10.3. |\r\n| lib/TinyMce/Provider/Assets.php | Add profile builder CSS and new i18n key for the `for_images` coupling hint. |\r\n| lang/sv_se.lang | Update “imagewidth” section wording and add `tinymce_imagewidth_plugin_hint`. |\r\n| lang/en_gb.lang | Update “imagewidth” section wording and add `tinymce_imagewidth_plugin_hint`. |\r\n| lang/de_de.lang | Update “imagewidth” section wording and add `tinymce_imagewidth_plugin_hint`. |\r\n| custom_plugins/snippets/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/quote/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/phonelink/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/mediapaste/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/link_yform/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_video/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_toc/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_oembed/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_markdown/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_images/src/main/ts/Plugin.ts | Internal refactor + delegate mediapool swap to `mceImage`. |\r\n| custom_plugins/for_images/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_htmlembed/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_footnotes/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_checklist/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_chars_symbols/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_abbr/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/for_a11y/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| custom_plugins/cleanpaste/package.json | Stop copying plugin dist into `assets/vendor/tinymce/plugins/`. |\r\n| CHANGELOG.md | Add 8.10.3 entry describing fixes and build-pipeline changes. |\r\n| assets/vendor/tinymce/plugins/snippets/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/snippets/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/quote/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/quote/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/quote/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/quote/LICENSE.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/quote/langs/de.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/quote/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/phonelink/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/phonelink/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/phonelink/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/phonelink/LICENSE.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/phonelink/langs/de.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/phonelink/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/mediapaste/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/mediapaste/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/mediapaste/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/link_yform/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/link_yform/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/link_yform/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/link_yform/LICENSE.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/link_yform/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_video/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_video/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_video/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_toc/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_toc/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_toc/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_oembed/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_oembed/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_oembed/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_markdown/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_images/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_images/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_images/LICENSE.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_images/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_htmlembed/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_htmlembed/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_htmlembed/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_footnotes/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_footnotes/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_footnotes/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_checklist/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_checklist/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_checklist/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_chars_symbols/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_abbr/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_abbr/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_abbr/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/for_a11y/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/cleanpaste/version.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/cleanpaste/plugin.min.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/cleanpaste/plugin.js | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/cleanpaste/LICENSE.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/vendor/tinymce/plugins/cleanpaste/CHANGELOG.txt | Remove custom plugin artifact from vendor tree. |\r\n| assets/scripts/base.js | Filter `external_plugins` against the profile’s active plugin list (fixes #171). |\r\n| assets/css/profile_builder.css | New styling for the profile assistant UI (light/dark). |\n</details>\n\n\n<details>\n<summary>Files not reviewed (1)</summary>\n\n* **assets/scripts/tinymce/plugins/for_images/plugin.js**: Language not supported\n</details>\n\n\n\n","state":"COMMENTED","html_url":"https://github.com/FriendsOfREDAXO/tinymce/pull/172#pullrequestreview-4324047091","pull_request_url":"https://api.github.com/repos/FriendsOfREDAXO/tinymce/pulls/172","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/FriendsOfREDAXO/tinymce/pull/172#pullrequestreview-4324047091"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfREDAXO/tinymce/pulls/172"}},"submitted_at":"2026-05-19T23:26:01Z","commit_id":"22325bb70124ca98752455acacf6ca86d94ee04e"},{"id":4324149014,"node_id":"PRR_kwDOCeJETc8AAAABAb1HFg","user":{"login":"copilot-pull-request-reviewer[bot]","id":175728472,"node_id":"BOT_kgDOCnlnWA","avatar_url":"https://avatars.githubusercontent.com/in/946600?v=4","gravatar_id":"","url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D","html_url":"https://github.com/apps/copilot-pull-request-reviewer","followers_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/followers","following_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/repos","events_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/copilot-pull-request-reviewer%5Bbot%5D/received_events","type":"Bot","user_view_type":"public","site_admin":false},"body":"## Pull request overview\n\nCopilot reviewed 33 out of 99 changed files in this pull request and generated 1 comment.\n\n<details>\n<summary>Files not reviewed (1)</summary>\n\n* **assets/scripts/tinymce/plugins/for_images/plugin.js**: Language not supported\n</details>\n\n\n\n","state":"COMMENTED","html_url":"https://github.com/FriendsOfREDAXO/tinymce/pull/172#pullrequestreview-4324149014","pull_request_url":"https://api.github.com/repos/FriendsOfREDAXO/tinymce/pulls/172","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/FriendsOfREDAXO/tinymce/pull/172#pullrequestreview-4324149014"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfREDAXO/tinymce/pulls/172"}},"submitted_at":"2026-05-19T23:52:08Z","commit_id":"fc4d47564bc9c936cf332d86b2aad7c40fe3f86d"}]
0 commit comments