minor #2208 remove deprecated config options (xabbuh)

This PR was merged into the 3.0-dev branch.

Discussion
----------

remove deprecated config options

Commits
-------

9f8f6fa remove deprecated config options

Author: xabbuh

CHANGELOG.md

@@ -37,7 +37,11 @@ CHANGELOG
   * `fos_rest.exception.exception_controller`
   * `fos_rest.exception.exception_listener`
   * `fos_rest.exception.service`
+  * `fos_rest.service.inflector`
   * `fos_rest.service.router`
+  * `fos_rest.service.templating`
+  * `fos_rest.view.default_engine`
+  * `fos_rest.view.force_redirects`
   * `fos_rest.view.templating_formats`
 
 * removed the following classes and interfaces:

DependencyInjection/Configuration.php

@@ -118,24 +118,8 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->arrayNode('service')
                     ->addDefaultsIfNotSet()
                     ->children()
-                        ->scalarNode('templating')
-                            ->defaultNull()
-                            ->validate()
-                                ->ifString()
-                                ->thenInvalid('only null is supported')
-                            ->end()
-                            ->setDeprecated('The "%path%.%node%" option is deprecated since FOSRestBundle 2.8.')
-                        ->end()
                         ->scalarNode('serializer')->defaultNull()->end()
                         ->scalarNode('view_handler')->defaultValue('fos_rest.view_handler.default')->end()
-                        ->scalarNode('inflector')
-                            ->defaultNull()
-                            ->validate()
-                                ->ifString()
-                                ->thenInvalid('only null is supported')
-                            ->end()
-                            ->setDeprecated('The "%path%.%node%" option is deprecated since FOSRestBundle 2.8.')
-                        ->end()
                         ->scalarNode('validator')->defaultValue('validator')->end()
                     ->end()
                 ->end()
@@ -196,24 +180,6 @@ private function addViewSection(ArrayNodeDefinition $rootNode): void
                     ->fixXmlConfig('force_redirect', 'force_redirects')
                     ->addDefaultsIfNotSet()
                     ->children()
-                        ->scalarNode('default_engine')
-                            ->defaultNull()
-                            ->validate()
-                                ->ifString()
-                                ->thenInvalid('only null is supported')
-                            ->end()
-                            ->setDeprecated('The "%path%.%node%" option has been deprecated in FOSRestBundle 2.8.')
-                        ->end()
-                        ->arrayNode('force_redirects')
-                            ->setDeprecated('The "%path%.%node%" option has been deprecated in FOSRestBundle 2.8.')
-                            ->useAttributeAsKey('name')
-                            ->defaultValue([])
-                            ->validate()
-                                ->ifTrue(function ($v) { return [] !== $v; })
-                                ->thenInvalid('only the empty array is supported')
-                            ->end()
-                            ->prototype('boolean')->end()
-                        ->end()
                         ->arrayNode('mime_types')
                             ->canBeEnabled()
                             ->beforeNormalization()

Tests/DependencyInjection/ConfigurationTest.php

@@ -215,50 +215,6 @@ public function incorrectExceptionCodeProvider()
         ];
     }
 
-    public function testTemplatingServiceMustBeNull()
-    {
-        $this->expectException(InvalidConfigurationException::class);
-        $this->expectExceptionMessage('only null is supported');
-
-        $this->processor->processConfiguration($this->configuration, [
-            [
-                'service' => [
-                    'templating' => 'twig',
-                ],
-            ],
-        ]);
-    }
-
-    public function testDefaultEngineMustBeNull()
-    {
-        $this->expectException(InvalidConfigurationException::class);
-        $this->expectExceptionMessage('only null is supported');
-
-        $this->processor->processConfiguration($this->configuration, [
-            [
-                'view' => [
-                    'default_engine' => 'twig',
-                ],
-            ],
-        ]);
-    }
-
-    public function testForceRedirectsMustBeEmptyArray()
-    {
-        $this->expectException(InvalidConfigurationException::class);
-        $this->expectExceptionMessage('only the empty array is supported');
-
-        $this->processor->processConfiguration($this->configuration, [
-            [
-                'view' => [
-                    'force_redirects' => [
-                        'html' => true,
-                    ],
-                ],
-            ],
-        ]);
-    }
-
     /**
      * {@inheritdoc}
      */

Tests/DependencyInjection/FOSRestExtensionTest.php

@@ -581,17 +581,4 @@ public function testRegisterSerializerErrorRenderer()
         $this->assertTrue($this->container->hasAlias('error_renderer'));
         $this->assertSame('fos_rest.error_renderer.serializer', (string) $this->container->getAlias('error_renderer'));
     }
-
-    public function testLegacyAliasesAreDeprecated()
-    {
-        if (!method_exists(Alias::class, 'isDeprecated')) {
-            $this->markTestSkipped();
-        }
-
-        $this->extension->load([], $this->container);
-
-        $this->assertTrue($this->container->getAlias('fos_rest.inflector')->isDeprecated());
-        $this->assertTrue($this->container->getAlias('fos_rest.router')->isDeprecated());
-        $this->assertTrue($this->container->getAlias('fos_rest.templating')->isDeprecated());
-    }
 }