Fix APC cache tests

- Using negative TTLs to force immediate expiration of keys, while convenient in tests, doesn't work consistently with APC and is an undocumented feature. Using a low TTL and sleep() is what garantees that it works for APC. See krakjoe/apcu#184

- The setting apc.use_request_time interferes with key expiration when running on CLI. Making sure it always has the sensible value for running the tests. See krakjoe/apcu#392

Author: mentalstring

test/unit/cache/sfAPCCacheTest.php

@@ -39,4 +39,8 @@
 $cache = new sfAPCCache();
 $cache->initialize();
 
+// make sure expired keys are dropped
+// see https://github.com/krakjoe/apcu/issues/391
+ini_set('apc.use_request_time', 0);
+
 sfCacheDriverTests::launch($t, $cache);

test/unit/cache/sfCacheDriverTests.class.php

@@ -18,7 +18,8 @@ static public function launch($t, $cache)
     $t->is($cache->get('test'), $data, '->get() retrieves data form the cache');
     $t->is($cache->has('test'), true, '->has() returns true if the cache exists');
 
-    $t->ok($cache->set('test', $data, -10), '->set() takes a lifetime as its third argument');
+    $t->ok($cache->set('test', $data, 1), '->set() takes a lifetime as its third argument');
+    sleep(2);
     $t->is($cache->get('test', 'default'), 'default', '->get() returns the default value if cache has expired');
     $t->is($cache->has('test'), false, '->has() returns true if the cache exists');
 
@@ -47,21 +48,24 @@ static public function launch($t, $cache)
     // ->clean()
     $t->diag('->clean()');
     $data = 'some random data to store in the cache system...';
-    $cache->set('foo', $data, -10);
+    $cache->set('foo', $data, 1);
+    sleep(2);
     $cache->set('bar', $data, 86400);
 
     $cache->clean(sfCache::OLD);
     $t->is($cache->has('foo'), false, '->clean() cleans old cache key if given the sfCache::OLD argument');
     $t->is($cache->has('bar'), true, '->clean() cleans old cache key if given the sfCache::OLD argument');
 
-    $cache->set('foo', $data, -10);
+    $cache->set('foo', $data, 1);
+    sleep(2);
     $cache->set('bar', $data, 86400);
 
     $cache->clean(sfCache::ALL);
     $t->is($cache->has('foo'), false, '->clean() cleans all cache key if given the sfCache::ALL argument');
     $t->is($cache->has('bar'), false, '->clean() cleans all cache key if given the sfCache::ALL argument');
 
-    $cache->set('foo', $data, -10);
+    $cache->set('foo', $data, 1);
+    sleep(2);
     $cache->set('bar', $data, 86400);
 
     $cache->clean();
@@ -128,7 +132,8 @@ static public function launch($t, $cache)
       $t->ok($delta >= $lifetime - 1 && $delta <= $lifetime, '->getTimeout() returns the timeout time for a given cache key');
     }
 
-    $cache->set('bar', 'foo', -10);
+    $cache->set('bar', 'foo', 1);
+    sleep(2);
     $t->is($cache->getTimeout('bar'), 0, '->getTimeout() returns the timeout time for a given cache key');
 
     foreach (array(86400, 10) as $lifetime)
@@ -152,7 +157,8 @@ static public function launch($t, $cache)
       $t->ok($lastModified >= time() - 1 && $lastModified <= time(), '->getLastModified() returns the last modified time for a given cache key');
     }
 
-    $cache->set('bar', 'foo', -10);
+    $cache->set('bar', 'foo', 1);
+    sleep(2);
     $t->is($cache->getLastModified('bar'), 0, '->getLastModified() returns the last modified time for a given cache key');
 
     foreach (array(86400, 10) as $lifetime)