Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove P2PService NetworkCodec trait #2368

Open
acerone85 opened this issue Oct 17, 2024 · 0 comments · May be fixed by #2388
Open

Remove P2PService NetworkCodec trait #2368

acerone85 opened this issue Oct 17, 2024 · 0 comments · May be fixed by #2388
Assignees

Comments

@acerone85
Copy link
Contributor

acerone85 commented Oct 17, 2024

Context

In the P2P service, we define a CodecTrait that can be defined for any struct implementing both GossipsubCodec and RequestResponse::Codec. See
See

pub trait NetworkCodec:
.

However, this trait only defines functions that are relevant to the RequestResponse protocol, namely iterating over all protocols available. Furthermore, it constrains the types of messages sent via GossipSub or Request/Response to be the same, which is unnecessary coupling between the two.

Acceptance criteria

The NetworkCodec trait is removed from the codebase, and the FuelService is refactored to not use this codec.

Relevant files:

@acerone85 acerone85 changed the title Remove P2PService network codec Remove P2PService NetworkCodec trait Oct 17, 2024
@acerone85 acerone85 self-assigned this Oct 23, 2024
@acerone85 acerone85 linked a pull request Oct 23, 2024 that will close this issue
17 tasks
@acerone85 acerone85 linked a pull request Oct 23, 2024 that will close this issue
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant