Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully implement #[deprecated] attribute #6942

Open
3 tasks
ironcev opened this issue Feb 19, 2025 · 0 comments
Open
3 tasks

Fully implement #[deprecated] attribute #6942

ironcev opened this issue Feb 19, 2025 · 0 comments
Assignees
@IGI-111
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged team:compiler Compiler Team

Comments

@ironcev
Copy link
Member

ironcev commented Feb 19, 2025 •
edited
Loading

Currently, only structs can be marked as #[deprecated] and the warning for using deprecated structs will not be emitted for all expressions in which a struct can be used.

Since we do not emit any error or warning for using #[deprecated] aside of stucts, this leads to a misleading usage, where items are annotated as #[depricated] but that annotation does not have any effect.

E.g., some examples of using #[deprecated] without any effect in the standard library:

  • std::constants::ZERO_B256
  • std::ecr::ec_recover
  • std::evm::ecr::ec_recover_evm_address

Warning for usages of #[deprecated] outside of struct declarations will be done in #6880.

This issues calls for step-wise implementation of #[deprecated] in the following directions:

  • allowing it on all elements where it makes sense.
  • checking for usages of deprecated items in all places.
  • supporting deprecating parent elements and propagating the deprecation to all child elements. E.g., if we deprecated the whole module by annotating the module kind as #[deprecated] this should deprecated all the items in that module. Same is with deprecating, e.g., impls.
@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen team:compiler Compiler Team labels Feb 19, 2025
@IGI-111 IGI-111 self-assigned this Feb 19, 2025
IGI-111 added a commit that referenced this issue Feb 20, 2025
@IGI-111
Extend #[deprecated] support
1ece71a 
Add support for the `#[deprecated]` attribute to functions, enums,
struct items, enum variants and propagate deprecation check exhaustively
throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their
definitions is still missing, as well as scrutinees and storage fields.
@IGI-111 IGI-111 mentioned this issue Feb 20, 2025
Merged
8 tasks
IGI-111 added a commit that referenced this issue Feb 20, 2025
@IGI-111
Extend #[deprecated] support
5be38d1 
Add support for the `#[deprecated]` attribute to functions, enums,
struct items, enum variants and propagate deprecation check exhaustively
throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their
definitions is still missing, as well as scrutinees and storage fields.
IGI-111 added a commit that referenced this issue Feb 20, 2025
@IGI-111
Extend #[deprecated] support
698fc62 
Add support for the `#[deprecated]` attribute to functions, enums,
struct items, enum variants and propagate deprecation check exhaustively
throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their
definitions is still missing, as well as scrutinees and storage fields.
IGI-111 added a commit that referenced this issue Feb 24, 2025
@IGI-111
Extend #[deprecated] support
170f80f 
Add support for the `#[deprecated]` attribute to functions, enums,
struct items, enum variants and propagate deprecation check exhaustively
throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their
definitions is still missing, as well as scrutinees and storage fields.
IGI-111 added a commit that referenced this issue Feb 24, 2025
@IGI-111
Extend #[deprecated] support
f5f4325 
Add support for the `#[deprecated]` attribute to functions, enums,
struct items, enum variants and propagate deprecation check exhaustively
throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their
definitions is still missing, as well as scrutinees and storage fields.
IGI-111 added a commit that referenced this issue Feb 24, 2025
@IGI-111
Extend #[deprecated] support
cde768f 
Add support for the `#[deprecated]` attribute to functions, enums,
struct items, enum variants and propagate deprecation check exhaustively
throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their
definitions is still missing, as well as scrutinees and storage fields.
ironcev pushed a commit that referenced this issue Feb 25, 2025
@IGI-111
Extend #[deprecated] support (#6944)
f871a48 
## Description

Add support for the `#[deprecated]` attribute to functions, enums,
struct items, enum variants and propagate deprecation check exhaustively
throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their
definitions is still missing, as well as scrutinees and storage fields.


## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IGI-111 IGI-111

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged team:compiler Compiler Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ironcev @IGI-111