Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attribute checks to type checking phase #6987

Open
ironcev opened this issue Mar 4, 2025 · 0 comments
Open

Move attribute checks to type checking phase #6987

ironcev opened this issue Mar 4, 2025 · 0 comments

Comments

@ironcev
Copy link
Member

ironcev commented Mar 4, 2025

#6986 defines a single place to check attribute's properties, in the convert_parse_tree. This means that modules with attribute issues will now consistently not reach the type checking phase. This was previously the case for some of the issues with attributes where custom checks where done during the type checking phase.

Checking attribute properties can be moved after the tree conversion phase, except the checks for #[cfg]. The benefit is the continuation of compilation until the end of module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant