Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant ABI cloning in deploy_executables function #6997

Open
zees-dev opened this issue Mar 6, 2025 · 0 comments
Open

Remove redundant ABI cloning in deploy_executables function #6997

zees-dev opened this issue Mar 6, 2025 · 0 comments
Labels
ABI Everything to do the ABI, especially the JSON representation code quality team:tooling Tooling Team

Comments

@zees-dev
Copy link
Contributor

zees-dev commented Mar 6, 2025

Cloning large ABI's can result in performance issues; hence where possible - we should try to propagate down references (ideally wrapped in Arc).
One such case has been identified in the PR/comment: #6996 (comment)

In this piece of code the inner ABI is being cloned, instead of the reference count of the Arc incremented.

The code will need to be refactored such that the inner ABI is not cloned.
@zees-dev zees-dev added ABI Everything to do the ABI, especially the JSON representation code quality team:tooling Tooling Team labels Mar 6, 2025
@zees-dev zees-dev mentioned this issue Mar 6, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ABI Everything to do the ABI, especially the JSON representation code quality team:tooling Tooling Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zees-dev