Skip to content

Commit 34722c3

Browse files
committed
feat: Improve UX of forms on mobile devices ✨
1 parent 0789a6c commit 34722c3

File tree

4 files changed

+21
-7
lines changed

4 files changed

+21
-7
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"vite-plugin-svgr": "3.2.0"
2626
},
2727
"scripts": {
28-
"start": "vite",
28+
"start": "vite --host",
2929
"build": "vite build",
3030
"serve": "vite preview"
3131
},

src/components/Letters.jsx

+5-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const Letter = ({ onNextPage }) => {
3838
return (
3939
<Fade timeout={500} in={isShown} appear={isShown}>
4040
<Paper className="start-container">
41-
<form noValidate autoComplete="off">
41+
<form noValidate autoComplete="off" onSubmit={solve}>
4242
<div className="start-container-item">
4343
<center>
4444
<Typography variant="h4">Name The Inputs</Typography>
@@ -47,12 +47,14 @@ const Letter = ({ onNextPage }) => {
4747
<div className="start-container-item">
4848
<TextField
4949
id="outlined-basic"
50-
label={`Enter ${varStore.initInputsNumber} Letters`}
50+
label={`Enter ${varStore.initInputsNumber} letters`}
51+
placeholder={Array(varStore.initInputsNumber).fill(0).map((_, i) => String.fromCharCode(65 + i)).join("")}
5152
helperText={errMsg ? errMsg : null}
5253
error={!!errMsg}
5354
onChange={handleChange}
5455
size="small"
5556
variant="filled"
57+
autoFocus
5658
/>
5759
</div>
5860
<div className="start-container-item">
@@ -61,6 +63,7 @@ const Letter = ({ onNextPage }) => {
6163
endIcon={<CalculateRounded />}
6264
variant="contained"
6365
color="primary"
66+
type="submit"
6467
onClick={solve}
6568
>
6669
Solve

src/components/Start.jsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ const Start = ({ onNextPage }) => {
6969
return (
7070
<Fade timeout={500} in={isShown} appear={isShown}>
7171
<Paper className="start-container">
72-
<form noValidate autoComplete="off">
72+
<form noValidate autoComplete="off" onSubmit={nextPage}>
7373
<div className="start-container-item">
7474
<center>
7575
<Typography variant="h4" className="logo">
@@ -82,6 +82,7 @@ const Start = ({ onNextPage }) => {
8282
<TextField
8383
id="minterms"
8484
label="Minterms"
85+
placeholder="(e.g. 0, 1, 2, 5, 7, 8, 9, 10, 13, 15)"
8586
helperText={mintermsErrMsg ? mintermsErrMsg : null}
8687
error={!!mintermsErrMsg}
8788
onChange={handleMintermsChange}
@@ -93,6 +94,7 @@ const Start = ({ onNextPage }) => {
9394
<TextField
9495
id="donot-cares"
9596
label="Don't Cares"
97+
placeholder="(e.g. 3, 4)"
9698
helperText={donotCaresErrMsg ? donotCaresErrMsg : null}
9799
error={!!donotCaresErrMsg}
98100
onChange={handleDonotCaresChange}
@@ -132,6 +134,7 @@ const Start = ({ onNextPage }) => {
132134
endIcon={<ArrowForwardRounded />}
133135
variant="contained"
134136
color="primary"
137+
type="submit"
135138
onClick={nextPage}
136139
>
137140
Next

src/styles.css

+11-3
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,32 @@
1-
.root {
1+
body {
2+
position: absolute;
23
background-image: url(./assets/img/bg.jpg);
34
background-repeat: no-repeat;
45
background-attachment: fixed;
56
background-size: cover;
7+
background-color: #073741;
68
overflow-x: hidden;
9+
overflow-y: auto;
10+
min-height: 100%;
11+
width: 100%;
12+
margin: 0;
713
}
814

915
.centering-root {
1016
display: flex;
11-
min-height: 100vh;
1217
margin: 0;
18+
max-width: calc(100% - 30px);
1319
padding-left: 15px;
1420
padding-right: 15px;
1521
justify-content: center;
22+
align-items: center;
1623
}
1724

1825
.centered-container {
1926
align-self: center;
2027
width: 100%;
2128
max-width: 600px;
29+
margin: 15px 0;
2230
}
2331

2432
.start-container {
@@ -39,7 +47,7 @@
3947
}
4048

4149
.mansory {
42-
margin: 0 auto;
50+
margin: 15px auto;
4351
}
4452

4553
.grid-item {

0 commit comments

Comments
 (0)