New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`Move To Package` menu item gets walkback when moving class-side methods #1007

Open

dalehenrich opened this issue Feb 2, 2024 · 0 comments

Assignees

Labels

Member

dalehenrich commented Feb 2, 2024

Looks like RowanClassService >> moveMethodSelectors:toPackageNamed: uses the theClass instead of theClass class:

moveMethodSelectors: methodSelectors toPackageNamed: thePackageName
	| targetPackageService |
	methodSelectors
		do: [ :selector | self theClass rwMoveMethod: selector toPackage: thePackageName ].
	self update.
	targetPackageService := (RowanPackageService forPackageNamed: thePackageName)
		update.
	(RowanProjectService new name: targetPackageService projectName) update

I've marked this as P1-critical, but in the grand scale of things JfP is more important at the moment ...
walkback.txt

The text was updated successfully, but these errors were encountered:

dalehenrich added the P1-critical label

dalehenrich assigned ericwinger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment