Issue #953: checkpoint addressing regressions from new round of battery tests: update expeted tests results for battery test; address regression in RwTestProjectLibraryGeneratorTestV3>>testRowanSample12LibraryGenerator

Author: dalehenrich

rowan/src/Rowan-TestsV3/RwRowanSample12TestProjectLibraryGenerator.class.st

@@ -58,13 +58,19 @@ RwRowanSample12TestProjectLibraryGenerator >> _addDefinitionsFor_0003: resolvedP
 
 { #category : 'private' }
 RwRowanSample12TestProjectLibraryGenerator >> _addDefinitionsFor_0005: resolvedProject [
+	^ self
+		_addDefinitionsFor_0005: resolvedProject
+		requiredProjectName: 'RowanSample9V3'
+]
+
+{ #category : 'private' }
+RwRowanSample12TestProjectLibraryGenerator >> _addDefinitionsFor_0005: resolvedProject requiredProjectName: requiredProjectName [
 	"Start with spec_0000. The class RowanSample12ConcreteClass1 subclasses AbstractRowanSample9ParentClass1 in RowanSample9:spec_0069, component Parent. RowanSample9. RowanSample9:spec_0069 componant Parent has the test. This spec requires RowanSample9:spec_0069."
 
-	| className packageName requiredLoadSpec requiredSpecName requiredProjectName componentName requiredRevision requiredComponentName |
+	| className packageName requiredLoadSpec requiredSpecName componentName requiredRevision requiredComponentName |
 	componentName := 'Core'.
 	packageName := projectName , '-' , componentName.
 	className := projectName , 'ConcreteClass1'.
-	requiredProjectName := 'RowanSample9V4'.
 	requiredComponentName := 'Parent'.
 	requiredSpecName := requiredProjectName , '_' , requiredComponentName.
 	requiredRevision := 'spec_0069'.

rowan/src/Rowan-TestsV3/RwTestProjectLibraryGeneratorTestV3.extension.st

@@ -239,5 +239,7 @@ RwTestProjectLibraryGeneratorTestV3 >> testRowanSample12LibraryGenerator [
 		genSpec_0004: commitComment;
 		genSpec_0005: commitComment;
 		genSpec_0006: commitComment;
+		genSpec_0007: commitComment;
+		genSpec_0008: commitComment;
 		yourself
 ]

rowan/src/Rowan-TestsV4/RwRowanSample12TestProjectLibraryGenerator.extension.st

@@ -174,7 +174,7 @@ RwRowanSample12TestProjectLibraryGenerator >> genSpec_0008: commitMessage [
 	resolvedRepository := self
 		_genSpecFor: specName
 		definedProject: definedProject
-		addDefinitions: [ :resolvedProject | self _addDefinitionsFor_0005: resolvedProject ].
+		addDefinitions: [ :resolvedProject | self _addDefinitionsFor_0005: resolvedProject requiredProjectName: 'RowanSample9V4' ].
 
 	self
 		_finishCommitAndPush: specName

tests/expectedV30TestResults_generatorV4.json

@@ -2,49 +2,31 @@
 	"branch" : "",
 	"commitSha" : "",
 	"deprecationWarnings" : [ ],
-	"gsVersion" : "3.7.2",
+	"gsVersion" : "3.7.3.1",
 	"notes" : "",
 	"properties" : { },
 	"resultsSummary" : {
 		"errors" : 0,
 		"failures" : 0,
-		"passed" : 5,
-		"summary" : "5 Tests with 0 Failures, 0 Errors and 0 DeprecationWarnings in 354.95s",
-		"tests" : 5,
-		"time" : 354.948
+		"passed" : 2,
+		"summary" : "2 Tests with 0 Failures, 0 Errors and 0 DeprecationWarnings in 316.08s",
+		"tests" : 2,
+		"time" : 316.076
 	},
 	"suiteName" : "Rowan projects Test Suite",
 	"testCases" : [
 		{
-			"className" : "RwTestProjectLibraryGeneratorTestV3",
+			"className" : "RwTestProjectLibraryGeneratorTestV4",
 			"status" : "passed",
-			"selector" : "testLibrarySample9V3Generator",
+			"selector" : "testLibrarySample9V4Generator",
 			"time" : "0"
 		},
 		{
-			"className" : "RwTestProjectLibraryGeneratorTestV3",
+			"className" : "RwTestProjectLibraryGeneratorTestV4",
 			"status" : "passed",
-			"selector" : "testLibrarySample9V3UniqueGenerator",
-			"time" : "0"
-		},
-		{
-			"className" : "RwTestProjectLibraryGeneratorTestV3",
-			"status" : "passed",
-			"selector" : "testRowanSample10V3LibraryGenerator",
-			"time" : "0"
-		},
-		{
-			"className" : "RwTestProjectLibraryGeneratorTestV3",
-			"status" : "passed",
-			"selector" : "testRowanSample11LibraryGenerator",
-			"time" : "0"
-		},
-		{
-			"className" : "RwTestProjectLibraryGeneratorTestV3",
-			"status" : "passed",
-			"selector" : "testRowanSample12LibraryGenerator",
+			"selector" : "testLibrarySample9V4UniqueGenerator",
 			"time" : "0"
 		}
 	],
-	"timeStamp" : "2024-05-10T20:37:58.409288-07:00"
+	"timeStamp" : "2025-03-08T15:18:09.907109-08:00"
 }