Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RwGitTool>>gitstatusIn:with: misbehaves when repositoryRootPath is not the root of a git repository #945

Open
dalehenrich opened this issue Feb 5, 2025 · 0 comments

Comments

@dalehenrich
Copy link
Member

There is a project that is embedded in another git project and Rowan guesses wrong when it decides that the project is a git project ... RwGitTool>>gitstatusIn:with: can return bogus status information:

(Rowan gitTools gitstatusIn: self repositoryRootPath with: '--porcelain')
"'?? rowan/
?? src/
'"

in this case the rowan and src directories are nowhere to be found ... and the git repository that the project is sitting in has not modifications ...
Here are the repositoryRootPaths for the two projects:

{
(Rowan projectNamed: 'gemstoneBaseImage') repositoryRootPath.
(Rowan projectNamed: 'generateGs') repositoryRootPath.
}
 "anArray( 
    '/bosch1/users/dhenrich/_stones/37x/f_37x', 
    '/bosch1/users/dhenrich/_stones/37x/f_37x/build/generateGs/projects/generateGs')"

The root cause of this is that the generateGs is incorrectly identified as a git project:

{
(Rowan projectNamed: 'gemstoneBaseImage') useGit.
(Rowan projectNamed: 'generateGs') useGit.
}
 "anArray( true, true)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant