Refactor packet hash logic to ObjectTranslator class

JusterZhu · JusterZhu · commit f6082e48354a · 2025-08-27T18:03:41.000+08:00
Moved GetPacketHash method from AbstractBootstrap to a new ObjectTranslator class for better separation of concerns. Updated usages in GeneralClientBootstrap and GeneralUpdateBootstrap to use ObjectTranslator. Updated project files to include ObjectTranslator.
diff --git a/src/c#/GeneralUpdate.Bowl/GeneralUpdate.Bowl.csproj b/src/c#/GeneralUpdate.Bowl/GeneralUpdate.Bowl.csproj
@@ -78,6 +78,7 @@
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\Enum\ReportType.cs" Link="Common\ReportType.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\GlobalConfigInfo.cs" Link="Common\GlobalConfigInfo.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\GlobalConfigInfoOSS.cs" Link="Common\GlobalConfigInfoOSS.cs" />
+        <Compile Include="..\GeneralUpdate.Common\Shared\Object\ObjectTranslator.cs" Link="Common\ObjectTranslator.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\Packet.cs" Link="Common\Packet.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\ProcessInfo.cs" Link="Common\ProcessInfo.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\VersionInfo.cs" Link="Common\VersionInfo.cs" />
diff --git a/src/c#/GeneralUpdate.ClientCore/GeneralClientBootstrap.cs b/src/c#/GeneralUpdate.ClientCore/GeneralClientBootstrap.cs
@@ -419,21 +419,21 @@ private GeneralClientBootstrap AddListener<TArgs>(Action<object, TArgs> callback
 
     private void OnMultiDownloadStatistics(object sender, MultiDownloadStatisticsEventArgs e)
     {
-        var message = GetPacketHash(e.Version);
+        var message = ObjectTranslator.GetPacketHash(e.Version);
         GeneralTracer.Info($"Multi download statistics, {message}[BytesReceived]:{e.BytesReceived} [ProgressPercentage]:{e.ProgressPercentage} [Remaining]:{e.Remaining} [TotalBytesToReceive]:{e.TotalBytesToReceive} [Speed]:{e.Speed}");
         EventManager.Instance.Dispatch(sender, e);
     }
 
     private void OnMultiDownloadCompleted(object sender, MultiDownloadCompletedEventArgs e)
     {
-        var message = GetPacketHash(e.Version);
+        var message = ObjectTranslator.GetPacketHash(e.Version);
         GeneralTracer.Info($"Multi download completed, {message}[IsComplated]:{e.IsComplated}.");
         EventManager.Instance.Dispatch(sender, e);
     }
 
     private void OnMultiDownloadError(object sender, MultiDownloadErrorEventArgs e)
     {
-        var message = GetPacketHash(e.Version);
+        var message = ObjectTranslator.GetPacketHash(e.Version);
         GeneralTracer.Error($"Multi download error {message}.", e.Exception);
         EventManager.Instance.Dispatch(sender, e);
     }
diff --git a/src/c#/GeneralUpdate.ClientCore/GeneralUpdate.ClientCore.csproj b/src/c#/GeneralUpdate.ClientCore/GeneralUpdate.ClientCore.csproj
@@ -68,6 +68,7 @@
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\Enum\ReportType.cs" Link="Common\ReportType.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\GlobalConfigInfo.cs" Link="Common\GlobalConfigInfo.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\GlobalConfigInfoOSS.cs" Link="Common\GlobalConfigInfoOSS.cs" />
+        <Compile Include="..\GeneralUpdate.Common\Shared\Object\ObjectTranslator.cs" Link="Common\ObjectTranslator.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\Packet.cs" Link="Common\Packet.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\ProcessInfo.cs" Link="Common\ProcessInfo.cs" />
         <Compile Include="..\GeneralUpdate.Common\Shared\Object\VersionInfo.cs" Link="Common\VersionInfo.cs" />
diff --git a/src/c#/GeneralUpdate.Common/Internal/Bootstrap/AbstractBootstrap.cs b/src/c#/GeneralUpdate.Common/Internal/Bootstrap/AbstractBootstrap.cs
@@ -62,8 +62,5 @@ public TBootstrap Option<T>(UpdateOption<T> option, T value)
                 return default;
             }
         }
-        
-        protected string GetPacketHash(object version) => 
-            !GeneralTracer.IsTracingEnabled() ? string.Empty : $"[PacketHash]:{(version as VersionInfo).Hash} ";
     }
 }
diff --git a/src/c#/GeneralUpdate.Common/Shared/Object/ObjectTranslator.cs b/src/c#/GeneralUpdate.Common/Shared/Object/ObjectTranslator.cs
@@ -0,0 +1,7 @@
+﻿namespace GeneralUpdate.Common.Shared.Object;
+
+public sealed class ObjectTranslator
+{
+    public static string GetPacketHash(object version) => 
+        !GeneralTracer.IsTracingEnabled() ? string.Empty : $"[PacketHash]:{(version as VersionInfo).Hash} ";
+}
diff --git a/src/c#/GeneralUpdate.Core/GeneralUpdate.Core.csproj b/src/c#/GeneralUpdate.Core/GeneralUpdate.Core.csproj
@@ -71,6 +71,7 @@
     <Compile Include="..\GeneralUpdate.Common\Shared\Object\Enum\ReportType.cs" Link="Common\ReportType.cs" />
     <Compile Include="..\GeneralUpdate.Common\Shared\Object\GlobalConfigInfo.cs" Link="Common\GlobalConfigInfo.cs" />
     <Compile Include="..\GeneralUpdate.Common\Shared\Object\GlobalConfigInfoOSS.cs" Link="Common\GlobalConfigInfoOSS.cs" />
+    <Compile Include="..\GeneralUpdate.Common\Shared\Object\ObjectTranslator.cs" Link="Common\ObjectTranslator.cs" />
     <Compile Include="..\GeneralUpdate.Common\Shared\Object\Packet.cs" Link="Common\Packet.cs" />
     <Compile Include="..\GeneralUpdate.Common\Shared\Object\ProcessInfo.cs" Link="Common\ProcessInfo.cs" />
     <Compile Include="..\GeneralUpdate.Common\Shared\Object\VersionInfo.cs" Link="Common\VersionInfo.cs" />
diff --git a/src/c#/GeneralUpdate.Core/GeneralUpdateBootstrap.cs b/src/c#/GeneralUpdate.Core/GeneralUpdateBootstrap.cs
@@ -133,21 +133,21 @@ private GeneralUpdateBootstrap AddListener<TArgs>(Action<object, TArgs> callback
 
         private void OnMultiDownloadStatistics(object sender, MultiDownloadStatisticsEventArgs e)
         {
-            var message = GetPacketHash(e.Version);
+            var message = ObjectTranslator.GetPacketHash(e.Version);
             GeneralTracer.Info($"Multi download statistics, {message}[BytesReceived]:{e.BytesReceived} [ProgressPercentage]:{e.ProgressPercentage} [Remaining]:{e.Remaining} [TotalBytesToReceive]:{e.TotalBytesToReceive} [Speed]:{e.Speed}");
             EventManager.Instance.Dispatch(sender, e);
         }
 
         private void OnMultiDownloadCompleted(object sender, MultiDownloadCompletedEventArgs e)
         {
-            var message = GetPacketHash(e.Version);
+            var message = ObjectTranslator.GetPacketHash(e.Version);
             GeneralTracer.Info($"Multi download completed, {message}[IsComplated]:{e.IsComplated}.");
             EventManager.Instance.Dispatch(sender, e);
         }
 
         private void OnMultiDownloadError(object sender, MultiDownloadErrorEventArgs e)
         {
-            var message = GetPacketHash(e.Version);
+            var message = ObjectTranslator.GetPacketHash(e.Version);
             GeneralTracer.Error($"Multi download error {message}.", e.Exception);
             EventManager.Instance.Dispatch(sender, e);
         }

Original file line number	Diff line number	Diff line change
`@@ -419,21 +419,21 @@ private GeneralClientBootstrap AddListener<TArgs>(Action<object, TArgs> callback`
`419`	`419`
`420`	`420`	`private void OnMultiDownloadStatistics(object sender, MultiDownloadStatisticsEventArgs e)`
`421`	`421`	`{`
`422`		`- var message = GetPacketHash(e.Version);`
	`422`	`+ var message = ObjectTranslator.GetPacketHash(e.Version);`
`423`	`423`	`GeneralTracer.Info($"Multi download statistics, {message}[BytesReceived]:{e.BytesReceived} [ProgressPercentage]:{e.ProgressPercentage} [Remaining]:{e.Remaining} [TotalBytesToReceive]:{e.TotalBytesToReceive} [Speed]:{e.Speed}");`
`424`	`424`	`EventManager.Instance.Dispatch(sender, e);`
`425`	`425`	`}`
`426`	`426`
`427`	`427`	`private void OnMultiDownloadCompleted(object sender, MultiDownloadCompletedEventArgs e)`
`428`	`428`	`{`
`429`		`- var message = GetPacketHash(e.Version);`
	`429`	`+ var message = ObjectTranslator.GetPacketHash(e.Version);`
`430`	`430`	`GeneralTracer.Info($"Multi download completed, {message}[IsComplated]:{e.IsComplated}.");`
`431`	`431`	`EventManager.Instance.Dispatch(sender, e);`
`432`	`432`	`}`
`433`	`433`
`434`	`434`	`private void OnMultiDownloadError(object sender, MultiDownloadErrorEventArgs e)`
`435`	`435`	`{`
`436`		`- var message = GetPacketHash(e.Version);`
	`436`	`+ var message = ObjectTranslator.GetPacketHash(e.Version);`
`437`	`437`	`GeneralTracer.Error($"Multi download error {message}.", e.Exception);`
`438`	`438`	`EventManager.Instance.Dispatch(sender, e);`
`439`	`439`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,8 +62,5 @@ public TBootstrap Option<T>(UpdateOption<T> option, T value)`
`62`	`62`	`return default;`
`63`	`63`	`}`
`64`	`64`	`}`
`65`		`-`
`66`		`- protected string GetPacketHash(object version) =>`
`67`		`- !GeneralTracer.IsTracingEnabled() ? string.Empty : $"[PacketHash]:{(version as VersionInfo).Hash} ";`
`68`	`65`	`}`
`69`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -133,21 +133,21 @@ private GeneralUpdateBootstrap AddListener<TArgs>(Action<object, TArgs> callback`
`133`	`133`
`134`	`134`	`private void OnMultiDownloadStatistics(object sender, MultiDownloadStatisticsEventArgs e)`
`135`	`135`	`{`
`136`		`- var message = GetPacketHash(e.Version);`
	`136`	`+ var message = ObjectTranslator.GetPacketHash(e.Version);`
`137`	`137`	`GeneralTracer.Info($"Multi download statistics, {message}[BytesReceived]:{e.BytesReceived} [ProgressPercentage]:{e.ProgressPercentage} [Remaining]:{e.Remaining} [TotalBytesToReceive]:{e.TotalBytesToReceive} [Speed]:{e.Speed}");`
`138`	`138`	`EventManager.Instance.Dispatch(sender, e);`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`private void OnMultiDownloadCompleted(object sender, MultiDownloadCompletedEventArgs e)`
`142`	`142`	`{`
`143`		`- var message = GetPacketHash(e.Version);`
	`143`	`+ var message = ObjectTranslator.GetPacketHash(e.Version);`
`144`	`144`	`GeneralTracer.Info($"Multi download completed, {message}[IsComplated]:{e.IsComplated}.");`
`145`	`145`	`EventManager.Instance.Dispatch(sender, e);`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`private void OnMultiDownloadError(object sender, MultiDownloadErrorEventArgs e)`
`149`	`149`	`{`
`150`		`- var message = GetPacketHash(e.Version);`
	`150`	`+ var message = ObjectTranslator.GetPacketHash(e.Version);`
`151`	`151`	`GeneralTracer.Error($"Multi download error {message}.", e.Exception);`
`152`	`152`	`EventManager.Instance.Dispatch(sender, e);`
`153`	`153`	`}`