Fix ErrorProne issues for JavaLangClash bug pattern

This requires renaming Module classes that clash with java.lang.Module.

Signed-off-by: Edwin Kempin <[email protected]>
Change-Id: Ic094fd30aea87433ff8063afc44427350309ff85

Author: EdwinKempin

BUILD

@@ -11,7 +11,7 @@ gerrit_plugin(
     srcs = glob(["src/main/java/**/*.java"]),
     manifest_entries = [
         "Gerrit-PluginName: webhooks",
-        "Gerrit-Module: com.googlesource.gerrit.plugins.webhooks.Module",
+        "Gerrit-Module: com.googlesource.gerrit.plugins.webhooks.PluginModule",
         "Implementation-Title: webhooks plugin",
         "Implementation-URL: https://gerrit-review.googlesource.com/#/admin/projects/plugins/webhooks",
         "Implementation-Vendor: Gerrit Code Review",

src/main/java/com/googlesource/gerrit/plugins/webhooks/Module.java renamed to src/main/java/com/googlesource/gerrit/plugins/webhooks/PluginModule.java

@@ -29,11 +29,11 @@
 import java.util.concurrent.ScheduledExecutorService;
 import org.apache.http.impl.client.CloseableHttpClient;
 
-public class Module extends FactoryModule {
+public class PluginModule extends FactoryModule {
   private final ProcessorModule processors;
 
   @Inject
-  public Module(ProcessorModule processors) {
+  public PluginModule(ProcessorModule processors) {
     this.processors = processors;
   }
 

src/test/java/com/googlesource/gerrit/plugins/webhooks/rest/GetRemoteIT.java

@@ -34,7 +34,7 @@
 import org.eclipse.jgit.transport.RefSpec;
 import org.junit.Test;
 
-@TestPlugin(name = "webhooks", sysModule = "com.googlesource.gerrit.plugins.webhooks.Module")
+@TestPlugin(name = "webhooks", sysModule = "com.googlesource.gerrit.plugins.webhooks.PluginModule")
 public class GetRemoteIT extends LightweightPluginDaemonTest {
 
   @Test

src/test/java/com/googlesource/gerrit/plugins/webhooks/rest/UpdateRemoteIT.java

@@ -32,7 +32,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
-@TestPlugin(name = "webhooks", sysModule = "com.googlesource.gerrit.plugins.webhooks.Module")
+@TestPlugin(name = "webhooks", sysModule = "com.googlesource.gerrit.plugins.webhooks.PluginModule")
 public class UpdateRemoteIT extends LightweightPluginDaemonTest {
 
   private String fooEndpoint;