Skip to content

Commit 50c1b66

Browse files
lndmrkWebRTC LUCI CQ
authored and
WebRTC LUCI CQ
committed
Remove expired field trial UseTwccPlrForAna
Bug: webrtc:7058 Change-Id: I432d0df9cdf53d2de4e4b33a59807787c5a55772 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345480 Reviewed-by: Jakob Ivarsson‎ <[email protected]> Commit-Queue: Emil Lundmark <[email protected]> Reviewed-by: Elad Alon <[email protected]> Cr-Commit-Position: refs/heads/main@{#42064}
1 parent f29d297 commit 50c1b66

File tree

2 files changed

+2
-26
lines changed

2 files changed

+2
-26
lines changed

experiments/field_trials.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,6 @@ def bug_url(self) -> str:
164164
# POLICY_EXEMPT_FIELD_TRIALS_DIGEST.
165165
POLICY_EXEMPT_FIELD_TRIALS: FrozenSet[FieldTrial] = frozenset([
166166
# keep-sorted start
167-
FieldTrial('UseTwccPlrForAna',
168-
'webrtc:7058',
169-
date(2024, 4, 1)),
170167
FieldTrial('WebRTC-AddNetworkCostToVpn',
171168
'webrtc:13097',
172169
date(2024, 4, 1)),
@@ -914,7 +911,7 @@ def bug_url(self) -> str:
914911
]) # yapf: disable
915912

916913
POLICY_EXEMPT_FIELD_TRIALS_DIGEST: str = \
917-
'023f4ce749a699f0ab811093b9f568d604da28a8'
914+
'3026f839766eb90355893fa0f1af8e9bf0d0dca1'
918915

919916
REGISTERED_FIELD_TRIALS: FrozenSet[FieldTrial] = ACTIVE_FIELD_TRIALS.union(
920917
POLICY_EXEMPT_FIELD_TRIALS)

modules/audio_coding/audio_network_adaptor/fec_controller_plr_based.cc

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -14,27 +14,9 @@
1414
#include <utility>
1515

1616
#include "rtc_base/checks.h"
17-
#include "system_wrappers/include/field_trial.h"
1817

1918
namespace webrtc {
2019

21-
namespace {
22-
class NullSmoothingFilter final : public SmoothingFilter {
23-
public:
24-
void AddSample(float sample) override { last_sample_ = sample; }
25-
26-
absl::optional<float> GetAverage() override { return last_sample_; }
27-
28-
bool SetTimeConstantMs(int time_constant_ms) override {
29-
RTC_DCHECK_NOTREACHED();
30-
return false;
31-
}
32-
33-
private:
34-
absl::optional<float> last_sample_;
35-
};
36-
} // namespace
37-
3820
FecControllerPlrBased::Config::Config(
3921
bool initial_fec_enabled,
4022
const ThresholdCurve& fec_enabling_threshold,
@@ -57,10 +39,7 @@ FecControllerPlrBased::FecControllerPlrBased(
5739
FecControllerPlrBased::FecControllerPlrBased(const Config& config)
5840
: FecControllerPlrBased(
5941
config,
60-
webrtc::field_trial::FindFullName("UseTwccPlrForAna") == "Enabled"
61-
? std::unique_ptr<NullSmoothingFilter>(new NullSmoothingFilter())
62-
: std::unique_ptr<SmoothingFilter>(
63-
new SmoothingFilterImpl(config.time_constant_ms))) {}
42+
std::make_unique<SmoothingFilterImpl>(config.time_constant_ms)) {}
6443

6544
FecControllerPlrBased::~FecControllerPlrBased() = default;
6645

0 commit comments

Comments
 (0)