CommandBehavior is bit flags

Author: unageek

DuckDB.NET.Data/DuckDBCommand.cs

@@ -138,7 +138,9 @@ protected override DbDataReader ExecuteDbDataReader(CommandBehavior behavior)
     {
         EnsureConnectionOpen();
 
-        return new DuckDBDataReader(this, GetStatements(), behavior);
+        var closeConnection = behavior.HasFlag(CommandBehavior.CloseConnection);
+
+        return new DuckDBDataReader(this, GetStatements(), closeConnection);
     }
 
     public override void Prepare() { }

DuckDB.NET.Data/DuckDBDataReader.cs

@@ -12,7 +12,7 @@ namespace DuckDB.NET.Data;
 public class DuckDBDataReader : DbDataReader
 {
     private readonly DuckDBCommand command;
-    private readonly CommandBehavior behavior;
+    private readonly bool closeConnection;
 
     private DuckDBResult? currentResult;
     private DuckDBDataChunk? currentChunk;
@@ -31,10 +31,10 @@ public class DuckDBDataReader : DbDataReader
     private VectorDataReaderBase[] vectorReaders = [];
     private Dictionary<string, int> columnMapping = [];
 
-    internal DuckDBDataReader(DuckDBCommand command, IEnumerable<PreparedStatement.PreparedStatement> statements, CommandBehavior behavior)
+    internal DuckDBDataReader(DuckDBCommand command, IEnumerable<PreparedStatement.PreparedStatement> statements, bool closeConnection)
     {
         this.command = command;
-        this.behavior = behavior;
+        this.closeConnection = closeConnection;
         statementEnumerator = statements.GetEnumerator();
 
         InitNextReader();
@@ -386,7 +386,7 @@ public override void Close()
 
         closed = true;
 
-        if (behavior == CommandBehavior.CloseConnection)
+        if (closeConnection)
         {
             command.CloseConnection();
         }