fix reading project layers too early

The fix is not very scalable, might need to address this more thoroughly in the future

Author: nmaarnio

arho_feature_template/core/plan_manager.py

@@ -81,9 +81,7 @@ def __init__(self):
         self.feature_template_libraries = [
             FeatureTemplateLibrary.from_config_file(file) for file in feature_template_library_config_files()
         ]
-        self.regulation_group_libraries = [
-            RegulationGroupLibrary.from_config_file(file) for file in regulation_group_library_config_files()
-        ]
+        self.regulation_group_libraries = None
 
         # Initialize new feature dock
         self.new_feature_dock = NewFeatureDock(self.feature_template_libraries)
@@ -107,6 +105,14 @@ def __init__(self):
         self.lambda_service = LambdaService()
         self.lambda_service.jsons_received.connect(self.save_plan_jsons)
 
+    def get_regulation_group_libraries(self):
+        # Lazy initialization of regulation_group_libraries to avoid reading regulation code layer too early
+        if self.regulation_group_libraries is None:
+            self.regulation_group_libraries = [
+                RegulationGroupLibrary.from_config_file(file) for file in regulation_group_library_config_files()
+            ]
+        return self.regulation_group_libraries
+
     def toggle_identify_plan_features(self, activate: bool):  # noqa: FBT001
         if activate:
             self.previous_map_tool = iface.mapCanvas().mapTool()
@@ -171,7 +177,7 @@ def edit_plan(self):
             return
         plan_model = PlanLayer.model_from_feature(feature)
 
-        attribute_form = PlanAttributeForm(plan_model, self.regulation_group_libraries)
+        attribute_form = PlanAttributeForm(plan_model, self.get_regulation_group_libraries())
         if attribute_form.exec_():
             feature = save_plan(attribute_form.model)
 
@@ -202,7 +208,7 @@ def _plan_geom_digitized(self, feature: QgsFeature):
             return
 
         plan_model = Plan(geom=feature.geometry())
-        attribute_form = PlanAttributeForm(plan_model, self.regulation_group_libraries)
+        attribute_form = PlanAttributeForm(plan_model, self.get_regulation_group_libraries())
         if attribute_form.exec_():
             feature = save_plan(attribute_form.model)
             plan_to_be_activated = feature["id"]
@@ -229,7 +235,7 @@ def _plan_feature_geom_digitized(self, feature: QgsFeature):
 
         plan_feature.geom = feature.geometry()
         attribute_form = PlanFeatureForm(
-            plan_feature, title, [*self.regulation_group_libraries, regulation_group_library_from_active_plan()]
+            plan_feature, title, [*self.get_regulation_group_libraries(), regulation_group_library_from_active_plan()]
         )
         if attribute_form.exec_():
             save_plan_feature(attribute_form.model)
@@ -241,7 +247,7 @@ def edit_plan_feature(self, feature: QgsFeature, layer_name: str):
         # Geom editing handled with basic QGIS vertex editing?
         title = plan_feature.name if plan_feature.name else layer_name
         attribute_form = PlanFeatureForm(
-            plan_feature, title, [*self.regulation_group_libraries, regulation_group_library_from_active_plan()]
+            plan_feature, title, [*self.get_regulation_group_libraries(), regulation_group_library_from_active_plan()]
         )
         if attribute_form.exec_():
             save_plan_feature(attribute_form.model)

arho_feature_template/gui/tools/inspect_plan_features_tool.py

@@ -23,7 +23,7 @@ def __init__(self, canvas: QgsMapCanvas, layer_classes: list[PlanFeatureLayer]):
         self.canvas = canvas
 
         self.layer_classes = layer_classes
-        self.layers = [cls.get_from_project() for cls in layer_classes]
+        self.layers: list[QgsVectorLayer] | None = None
 
         self.highlighted: tuple[QgsFeature, str] | None = None
         self.highlight_rubber_band: QgsRubberBand | None = None
@@ -70,6 +70,11 @@ def query_nearby_features(self, point: QgsPointXY) -> dict[QgsVectorLayer, list[
         request = QgsFeatureRequest()
         request.setFilterRect(tolerance_geom)
         request.setFlags(QgsFeatureRequest.Flag.ExactIntersect)
+
+        # Lazy reading of feature layers to avoid reading them too early
+        if self.layers is None:
+            self.layers = [cls.get_from_project() for cls in self.layer_classes]
+
         with OverrideCursor(Qt.WaitCursor):
             for layer in self.layers:
                 features = list(layer.getFeatures(request))