remove most success messages, fix use_wait_cursor decorator

Author: nmaarnio

arho_feature_template/core/plan_manager.py

@@ -161,14 +161,10 @@ def update_active_plan_regulation_group_library(self):
         self.regulation_groups_dock.update_regulation_groups(self.active_plan_regulation_group_library)
 
     def create_new_regulation_group(self):
-        new_group = self._open_regulation_group_form(RegulationGroup())
-        if new_group:
-            iface.messageBar().pushSuccess(None, f"Kaavamääräysryhmä {new_group!s} luotiin onnistuneesti.")
+        self._open_regulation_group_form(RegulationGroup())
 
     def edit_regulation_group(self, regulation_group: RegulationGroup):
-        edited_group = self._open_regulation_group_form(regulation_group)
-        if edited_group:
-            iface.messageBar().pushSuccess(None, f"Kaavamääräysryhmää {edited_group!s} muokattiin onnistuneesti.")
+        self._open_regulation_group_form(regulation_group)
 
     def _open_regulation_group_form(self, regulation_group: RegulationGroup):
         regulation_group_form = PlanRegulationGroupForm(regulation_group, self.active_plan_regulation_group_library)
@@ -187,7 +183,6 @@ def _open_regulation_group_form(self, regulation_group: RegulationGroup):
 
     def delete_regulation_group(self, group: RegulationGroup):
         if delete_regulation_group(group):
-            iface.messageBar().pushSuccess(None, f"Kaavamääräysryhmä {group!s} poistettiin onnistuneesti.")
             self.update_active_plan_regulation_group_library()
 
     def toggle_identify_plan_features(self, activate: bool):  # noqa: FBT001
@@ -257,9 +252,6 @@ def edit_plan(self):
         if attribute_form.exec_():
             feature = save_plan(attribute_form.model)
             if feature:
-                iface.messageBar().pushSuccess(
-                    "", f"Kaavan {attribute_form.model.name} tietoja muokattiin onnistuneesti."
-                )
                 self.update_active_plan_regulation_group_library()
 
     def edit_lifecycles(self):
@@ -307,11 +299,7 @@ def _plan_geom_digitized(self, feature: QgsFeature):
         attribute_form = PlanAttributeForm(plan_model, self.regulation_group_libraries)
         if attribute_form.exec_():
             feat = save_plan(attribute_form.model)
-            if feat:
-                iface.messageBar().pushSuccess("", f"Kaava {attribute_form.model.name} luotiin onnistuneesti.")
-                plan_to_be_activated = feat["id"]
-            else:
-                plan_to_be_activated = self.previous_active_plan_id
+            plan_to_be_activated = feat["id"] if feat else self.previous_active_plan_id
         else:
             plan_to_be_activated = self.previous_active_plan_id
 
@@ -338,7 +326,6 @@ def _plan_feature_geom_digitized(self, feature: QgsFeature):
             plan_feature, title, self.regulation_group_libraries, self.active_plan_regulation_group_library
         )
         if attribute_form.exec_() and save_plan_feature(attribute_form.model):
-            iface.messageBar().pushSuccess("", f"Kaavakohde {attribute_form.model!s} luotiin onnistuneesti.")
             self.update_active_plan_regulation_group_library()
 
     def edit_plan_feature(self, feature: QgsFeature, layer_name: str):
@@ -350,7 +337,6 @@ def edit_plan_feature(self, feature: QgsFeature, layer_name: str):
             plan_feature, title, self.regulation_group_libraries, self.active_plan_regulation_group_library
         )
         if attribute_form.exec_() and save_plan_feature(attribute_form.model):
-            iface.messageBar().pushSuccess("", f"Kaavakohdetta {attribute_form.model!s} muokattiin onnistuneesti.")
             self.update_active_plan_regulation_group_library()
 
     def set_active_plan(self, plan_id: str | None):
@@ -393,13 +379,10 @@ def load_land_use_plan(self):
 
         if dialog.exec_() == QDialog.Accepted:
             selected_plan_id = dialog.get_selected_plan_id()
-            selected_plan_name = dialog.get_selected_plan_name()
             self.commit_all_editable_layers()
 
             self.set_active_plan(selected_plan_id)
 
-            iface.messageBar().pushSuccess("", f"Kaava {selected_plan_name} avattiin onnistuneesti.")
-
     def commit_all_editable_layers(self):
         """Commit all changes in any editable layers."""
         for layer in QgsProject.instance().mapLayers().values():
@@ -438,7 +421,7 @@ def save_plan_jsons(self, plan_json, outline_json):
         with open(self.json_plan_outline_path, "w", encoding="utf-8") as outline_file:
             json.dump(outline_json, outline_file, ensure_ascii=False, indent=2)
 
-        iface.messageBar().pushSuccess("", "Kaava ja sen ulkoraja tallennettu onnistuneesti.")
+        iface.messageBar().pushSuccess("", "Kaava ja kaavan ulkoraja tallennettu.")
 
     def unload(self):
         # Set pan map tool as active (to deactivate our custom tools to avoid errors)

arho_feature_template/utils/misc_utils.py

@@ -2,6 +2,7 @@
 
 import os
 from contextlib import suppress
+from functools import wraps
 from typing import TYPE_CHECKING, Any, cast
 
 from qgis.core import QgsExpressionContextUtils, QgsProject, QgsVectorLayer
@@ -131,6 +132,7 @@ def deserialize_localized_text(text_value: dict[str, str] | None | Any) -> str |
 
 
 def use_wait_cursor(func):
+    @wraps(func)
     def wrapper(*args, **kwargs):
         with OverrideCursor(Qt.WaitCursor):
             return func(*args, **kwargs)