Skip to content

Commit 4572606

Browse files
committed
Typing fixes, make mypy happy
1 parent 119e6d4 commit 4572606

File tree

3 files changed

+21
-19
lines changed

3 files changed

+21
-19
lines changed

arho_feature_template/gui/components/plan_regulation_widget.py

+2
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ def _add_action(parent_id: str, info_type: str, display_name: str):
118118

119119
for child_code in top_level_config.children:
120120
config = ai_config_library.get_config_by_code(child_code)
121+
if not config.name:
122+
continue
121123
_add_action(top_level_code, config.additional_information_type, config.name)
122124

123125
# Create main menu for btn and add submenus

arho_feature_template/gui/docks/new_feature_dock.py

+8-9
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,18 @@
2121

2222

2323
class NewFeatureDock(QgsDockWidget, DockClass): # type: ignore
24+
library_selection: QComboBox
25+
search_box: QgsFilterLineEdit
26+
template_list: QListWidget
27+
txt_tip: QLabel
28+
dockWidgetContents: QWidget # noqa: N815
29+
2430
tool_activated = pyqtSignal()
2531

26-
def __init__(self):
32+
def __init__(self) -> None:
2733
super().__init__()
2834
self.setupUi(self)
2935

30-
# TYPES
31-
self.library_selection: QComboBox
32-
self.search_box: QgsFilterLineEdit
33-
self.template_list: QListWidget
34-
self.txt_tip: QLabel
35-
self.dockWidgetContents: QWidget
36-
3736
# INIT
3837
# 1. New feature grid
3938
self.new_feature_grid = NewFeatureGridWidget()
@@ -66,7 +65,7 @@ def on_active_feature_type_changed(self, feature_name: str, layer_name: str):
6665
if self.active_feature_type:
6766
self.tool_activated.emit()
6867

69-
def filter_plan_feature_templates(self):
68+
def filter_plan_feature_templates(self) -> None:
7069
# Consider both search text and active plan feature type
7170
search_text = self.search_box.value().lower()
7271

arho_feature_template/gui/docks/regulation_groups_dock.py

+11-10
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from __future__ import annotations
2+
13
from importlib import resources
24
from typing import TYPE_CHECKING
35

@@ -20,6 +22,14 @@
2022

2123

2224
class RegulationGroupsDock(QgsDockWidget, DockClass): # type: ignore
25+
search_box: QgsFilterLineEdit
26+
regulation_group_list: QListWidget
27+
dockWidgetContents: QWidget # noqa: N815
28+
29+
new_btn: QPushButton
30+
delete_btn: QPushButton
31+
edit_btn: QPushButton
32+
2333
new_regulation_group_requested = pyqtSignal()
2434
edit_regulation_group_requested = pyqtSignal(RegulationGroup)
2535
delete_regulation_group_requested = pyqtSignal(RegulationGroup)
@@ -28,15 +38,6 @@ def __init__(self):
2838
super().__init__()
2939
self.setupUi(self)
3040

31-
# TYPES
32-
self.search_box: QgsFilterLineEdit
33-
self.regulation_group_list: QListWidget
34-
self.dockWidgetContents: QWidget
35-
36-
self.new_btn: QPushButton
37-
self.delete_btn: QPushButton
38-
self.edit_btn: QPushButton
39-
4041
self.new_btn.setIcon(QgsApplication.getThemeIcon("mActionAdd.svg"))
4142
self.delete_btn.setIcon(QgsApplication.getThemeIcon("mActionDeleteSelected.svg"))
4243
self.edit_btn.setIcon(QgsApplication.getThemeIcon("mActionEditTable.svg"))
@@ -115,7 +116,7 @@ def on_delete_btn_clicked(self):
115116
if response == QMessageBox.Yes:
116117
self.delete_regulation_group_requested.emit(self.selected_group)
117118

118-
def filter_regulation_groups(self):
119+
def filter_regulation_groups(self) -> None:
119120
search_text = self.search_box.value().lower()
120121

121122
for index in range(self.regulation_group_list.count()):

0 commit comments

Comments
 (0)