Re-enable validation after an error occurs

Re-enables validation button and hides progress bar if a the validation lambda call fails.

Author: Mtk112

arho_feature_template/core/lambda_service.py

@@ -15,6 +15,7 @@
 class LambdaService(QObject):
     jsons_received = pyqtSignal(dict, dict)
     validation_received = pyqtSignal(dict)
+    validation_failed = pyqtSignal()
     ActionAttribute = cast(QNetworkRequest.Attribute, QNetworkRequest.User + 1)
     ACTION_VALIDATE_PLANS = "validate_plans"
     ACTION_GET_PLANS = "get_plans"
@@ -58,9 +59,12 @@ def _is_api_gateway_request(self) -> bool:
         return bool(match)
 
     def _handle_reply(self, reply: QNetworkReply):
+        action = reply.request().attribute(LambdaService.ActionAttribute)
         if reply.error() != QNetworkReply.NoError:
             error = reply.errorString()
-            QMessageBox.critical(None, "API Error", f"Lambda call failed: {error}")
+            QMessageBox.critical(None, "API Virhe", f"Lambda kutsu epäonnistui: {error}")
+            if action == self.ACTION_VALIDATE_PLANS:
+                self.validation_failed.emit()
             reply.deleteLater()
             return
 
@@ -72,20 +76,23 @@ def _handle_reply(self, reply: QNetworkReply):
                 # If calling the lambda directly, the response includes status code and body
                 if int(response_json.get("statusCode", 0)) != HTTPStatus.OK:
                     error = response_json["body"] if "body" in response_json else response_json["errorMessage"]
-                    QMessageBox.critical(None, "API Error", f"Lambda call failed: {error}")
+                    QMessageBox.critical(None, "API Virhe", f"Lambda kutsu epäonnistui: {error}")
+                    if action == self.ACTION_VALIDATE_PLANS:
+                        self.validation_failed.emit()
                     reply.deleteLater()
                     return
                 body = response_json["body"]
             else:
                 body = response_json
 
         except (json.JSONDecodeError, KeyError) as e:
-            QMessageBox.critical(None, "JSON Error", f"Failed to parse response JSON: {e}")
+            QMessageBox.critical(None, "JSON Virhe", f"Vastauksen JSON-tiedoston jäsennys epäonnistui: {e}")
+            if action == self.ACTION_VALIDATE_PLANS:
+                self.validation_failed.emit()
             return
         finally:
             reply.deleteLater()
 
-        action = reply.request().attribute(LambdaService.ActionAttribute)
         if action == self.ACTION_GET_PLANS:
             self._process_json_reply(body)
         elif action == self.ACTION_VALIDATE_PLANS:
@@ -95,7 +102,6 @@ def _process_validation_reply(self, response_json: dict):
         """Processes the validation reply from the lambda and emits a signal."""
 
         validation_errors = response_json.get("ryhti_responses")
-
         self.validation_received.emit(validation_errors)
 
     def _process_json_reply(self, response_json: dict):

arho_feature_template/gui/docks/validation_dock.py

@@ -29,6 +29,7 @@ def __init__(self, parent=None):
 
         self.lambda_service = LambdaService()
         self.lambda_service.validation_received.connect(self.list_validation_errors)
+        self.lambda_service.validation_failed.connect(self.enable_validation)
         self.validate_button.clicked.connect(self.validate)
 
     def validate(self):
@@ -48,15 +49,25 @@ def validate(self):
 
         self.lambda_service.validate_plan(active_plan_id)
 
+    def enable_validation(self):
+        """Hide progress bar and re-enable the button"""
+        self.progress_bar.setVisible(False)
+        self.validate_button.setEnabled(True)
+        self.validation_result_tree_view.expandAll()
+        self.validation_result_tree_view.resizeColumnToContents(0)
+
     def list_validation_errors(self, validation_json):
         """Slot for listing validation errors and warnings."""
+
         if not validation_json:
             iface.messageBar().pushMessage("Virhe", "Validaatio json puuttuu.", level=1)
+            self.enable_validation()
             return
 
-        if not validation_json:
-            # If no errors or warnings, display a message and exit
+        # If no errors or warnings, display a message and exit
+        if not any(validation_json.values()):
             iface.messageBar().pushMessage("Virhe", "Ei virheitä havaittu.", level=1)
+            self.enable_validation()
             return
 
         for error_data in validation_json.values():
@@ -79,8 +90,5 @@ def list_validation_errors(self, validation_json):
                     warning.get("message", ""),
                 )
 
-        # Hide progress bar and re-enable the button
-        self.progress_bar.setVisible(False)
-        self.validate_button.setEnabled(True)
-        self.validation_result_tree_view.expandAll()
-        self.validation_result_tree_view.resizeColumnToContents(0)
+        # Always enable validation at the end
+        self.enable_validation()