Skip to content

Commit 5b57fcc

Browse files
committed
update plan proposition model (remove 'name' field)
1 parent e876d08 commit 5b57fcc

File tree

5 files changed

+18
-41
lines changed

5 files changed

+18
-41
lines changed

arho_feature_template/core/models.py

-1
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ class Regulation:
286286

287287
@dataclass
288288
class Proposition:
289-
name: str
290289
value: str
291290
theme_id: str | None = None
292291
proposition_number: int | None = None

arho_feature_template/gui/components/plan_proposition_widget.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from arho_feature_template.project.layers.code_layers import PlanThemeLayer
1515

1616
if TYPE_CHECKING:
17-
from qgis.PyQt.QtWidgets import QLineEdit, QPushButton
17+
from qgis.PyQt.QtWidgets import QPushButton
1818

1919
ui_path = resources.files(__package__) / "plan_proposition_widget.ui"
2020
FormClass, _ = uic.loadUiType(ui_path)
@@ -30,7 +30,6 @@ def __init__(self, proposition: Proposition, parent=None):
3030
self.setupUi(self)
3131

3232
# TYPES
33-
self.name: QLineEdit
3433
self.value_label: QLabel
3534
self.text_input: QTextEdit
3635
self.add_field_btn: QPushButton
@@ -58,7 +57,7 @@ def __init__(self, proposition: Proposition, parent=None):
5857
self.expanded = True
5958
self.expand_hide_btn.clicked.connect(self._on_expand_hide_btn_clicked)
6059

61-
self.name.setText(proposition.name)
60+
# self.name.setText(proposition.name)
6261
self.text_input.setText(proposition.value)
6362
if proposition.theme_id:
6463
self._add_theme(proposition.theme_id)
@@ -103,7 +102,6 @@ def _on_expand_hide_btn_clicked(self):
103102

104103
def into_model(self) -> Proposition:
105104
return Proposition(
106-
name=self.name.text(),
107105
value=self.text_input.toPlainText(),
108106
theme_id=self.theme_widget.value() if self.theme_widget else None,
109107
proposition_number=self.proposition_number_widget.get_value() if self.proposition_number_widget else None,

arho_feature_template/gui/components/plan_proposition_widget.ui

+15-33
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<x>0</x>
88
<y>0</y>
99
<width>441</width>
10-
<height>207</height>
10+
<height>125</height>
1111
</rect>
1212
</property>
1313
<property name="sizePolicy">
@@ -87,49 +87,31 @@
8787
</property>
8888
</widget>
8989
</item>
90+
<item>
91+
<widget class="QToolButton" name="expand_hide_btn">
92+
<property name="text">
93+
<string>Laajenna</string>
94+
</property>
95+
<property name="autoRaise">
96+
<bool>false</bool>
97+
</property>
98+
<property name="arrowType">
99+
<enum>Qt::UpArrow</enum>
100+
</property>
101+
</widget>
102+
</item>
90103
</layout>
91104
</item>
92105
<item>
93106
<layout class="QFormLayout" name="form_layout">
94107
<item row="0" column="0">
95-
<widget class="QLabel" name="name_label">
96-
<property name="text">
97-
<string>Otsikko</string>
98-
</property>
99-
</widget>
100-
</item>
101-
<item row="0" column="1">
102-
<layout class="QHBoxLayout" name="horizontalLayout_2">
103-
<item>
104-
<widget class="QLineEdit" name="name">
105-
<property name="clearButtonEnabled">
106-
<bool>false</bool>
107-
</property>
108-
</widget>
109-
</item>
110-
<item>
111-
<widget class="QToolButton" name="expand_hide_btn">
112-
<property name="text">
113-
<string>Laajenna</string>
114-
</property>
115-
<property name="autoRaise">
116-
<bool>false</bool>
117-
</property>
118-
<property name="arrowType">
119-
<enum>Qt::UpArrow</enum>
120-
</property>
121-
</widget>
122-
</item>
123-
</layout>
124-
</item>
125-
<item row="1" column="0">
126108
<widget class="QLabel" name="value_label">
127109
<property name="text">
128110
<string>Sisältö</string>
129111
</property>
130112
</widget>
131113
</item>
132-
<item row="1" column="1">
114+
<item row="0" column="1">
133115
<widget class="QTextEdit" name="text_input">
134116
<property name="sizePolicy">
135117
<sizepolicy hsizetype="Expanding" vsizetype="Preferred">

arho_feature_template/gui/dialogs/plan_regulation_group_form.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def delete_regulation(self, regulation_widget: RegulationWidget):
122122
regulation_widget.deleteLater()
123123

124124
def add_new_proposition(self):
125-
proposition = Proposition(name="", value="")
125+
proposition = Proposition(value="")
126126
self.add_proposition(proposition)
127127

128128
def add_proposition(self, proposition: Proposition):

arho_feature_template/project/layers/plan_layers.py

-2
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,6 @@ class PlanPropositionLayer(AbstractPlanLayer):
381381
def feature_from_model(cls, model: Proposition) -> QgsFeature:
382382
feature = cls.initialize_feature_from_model(model)
383383

384-
feature["name"] = {LANGUAGE: model.name}
385384
feature["text_value"] = {LANGUAGE: model.value}
386385
feature["plan_regulation_group_id"] = model.regulation_group_id_
387386
feature["ordering"] = model.proposition_number
@@ -393,7 +392,6 @@ def feature_from_model(cls, model: Proposition) -> QgsFeature:
393392
@classmethod
394393
def model_from_feature(cls, feature: QgsFeature) -> Proposition:
395394
return Proposition(
396-
name=feature["name"][LANGUAGE],
397395
value=feature["text_value"][LANGUAGE],
398396
regulation_group_id_=feature["plan_regulation_group_id"],
399397
proposition_number=feature["ordering"],

0 commit comments

Comments
 (0)