refactor regulation groups from active plan handling

Now PlanManager has a variable for reg. groups from active plan that is updated when needed.
Previously all regulation groups were read from DB every time reg. groups from active plan
were needed for some form.

Author: nmaarnio

arho_feature_template/core/plan_manager.py

@@ -101,8 +101,7 @@ def __init__(self):
         self.regulation_groups_dock.new_regulation_group_requested.connect(self.create_new_regulation_group)
         self.regulation_groups_dock.edit_regulation_group_requested.connect(self.edit_regulation_group)
         self.regulation_groups_dock.delete_regulation_group_requested.connect(self.delete_regulation_group)
-        if get_active_plan_id():
-            self.regulation_groups_dock.initialize_regulation_groups(regulation_group_library_from_active_plan())
+        self.update_active_plan_regulation_group_library()
         self.regulation_groups_dock.hide()
 
         # Initialize digitize tools
@@ -153,6 +152,10 @@ def initialize_libraries(self):
         ]
         self.new_feature_dock.initialize_feature_template_libraries(self.feature_template_libraries)
 
+    def update_active_plan_regulation_group_library(self):
+        self.active_plan_regulation_group_library = regulation_group_library_from_active_plan()
+        self.regulation_groups_dock.update_regulation_groups(self.active_plan_regulation_group_library)
+
     def create_new_regulation_group(self):
         self._open_regulation_group_form(RegulationGroup())
 
@@ -166,11 +169,11 @@ def _open_regulation_group_form(self, regulation_group: RegulationGroup):
                 save_regulation_group_as_config(regulation_group_form.model)
             else:
                 save_regulation_group(regulation_group_form.model)
-            self.regulation_groups_dock.initialize_regulation_groups(regulation_group_library_from_active_plan())
+            self.update_active_plan_regulation_group_library()
 
     def delete_regulation_group(self, group: RegulationGroup):
         delete_regulation_group(group)
-        self.regulation_groups_dock.initialize_regulation_groups(regulation_group_library_from_active_plan())
+        self.update_active_plan_regulation_group_library()
 
     def toggle_identify_plan_features(self, activate: bool):  # noqa: FBT001
         if activate:
@@ -238,7 +241,7 @@ def edit_plan(self):
         attribute_form = PlanAttributeForm(plan_model, self.regulation_group_libraries)
         if attribute_form.exec_():
             feature = save_plan(attribute_form.model)
-            self.regulation_groups_dock.initialize_regulation_groups(regulation_group_library_from_active_plan())
+            self.update_active_plan_regulation_group_library()
 
     def add_new_plan_feature(self):
         if not handle_unsaved_changes():
@@ -294,11 +297,11 @@ def _plan_feature_geom_digitized(self, feature: QgsFeature):
 
         plan_feature.geom = feature.geometry()
         attribute_form = PlanFeatureForm(
-            plan_feature, title, [*self.regulation_group_libraries, regulation_group_library_from_active_plan()]
+            plan_feature, title, [*self.regulation_group_libraries, self.active_plan_regulation_group_library]
         )
         if attribute_form.exec_():
             save_plan_feature(attribute_form.model)
-            self.regulation_groups_dock.initialize_regulation_groups(regulation_group_library_from_active_plan())
+            self.update_active_plan_regulation_group_library()
 
     def edit_plan_feature(self, feature: QgsFeature, layer_name: str):
         layer_class = FEATURE_LAYER_NAME_TO_CLASS_MAP[layer_name]
@@ -307,11 +310,11 @@ def edit_plan_feature(self, feature: QgsFeature, layer_name: str):
         # Geom editing handled with basic QGIS vertex editing?
         title = plan_feature.name if plan_feature.name else layer_name
         attribute_form = PlanFeatureForm(
-            plan_feature, title, [*self.regulation_group_libraries, regulation_group_library_from_active_plan()]
+            plan_feature, title, [*self.regulation_group_libraries, self.active_plan_regulation_group_library]
         )
         if attribute_form.exec_():
             save_plan_feature(attribute_form.model)
-            self.regulation_groups_dock.initialize_regulation_groups(regulation_group_library_from_active_plan())
+            self.update_active_plan_regulation_group_library()
 
     def set_active_plan(self, plan_id: str | None):
         """Update the project layers based on the selected land use plan.
@@ -336,8 +339,7 @@ def set_active_plan(self, plan_id: str | None):
         if previously_in_edit_mode:
             plan_layer.startEditing()
 
-        # Update regulation group dock
-        self.regulation_groups_dock.initialize_regulation_groups(regulation_group_library_from_active_plan())
+        self.update_active_plan_regulation_group_library()
 
     def load_land_use_plan(self):
         """Load an existing land use plan using a dialog selection."""
@@ -440,6 +442,11 @@ def unload(self):
 
 
 def regulation_group_library_from_active_plan() -> RegulationGroupLibrary:
+    if not get_active_plan_id():
+        return RegulationGroupLibrary(
+            name="Käytössä olevat kaavamääräysryhmät", version=None, description=None, regulation_group_categories=[]
+        )
+
     id_of_general_regulation_group_type = PlanRegulationGroupTypeLayer.get_attribute_value_by_another_attribute_value(
         "id", "value", "generalRegulations"
     )

arho_feature_template/gui/docks/regulation_groups_dock.py

@@ -64,7 +64,7 @@ def connect_buttons(self):
         self.edit_btn.clicked.connect(self.on_edit_btn_clicked)
         self.delete_btn.clicked.connect(self.on_delete_btn_clicked)
 
-    def initialize_regulation_groups(self, regulation_group_library: RegulationGroupLibrary):
+    def update_regulation_groups(self, regulation_group_library: RegulationGroupLibrary):
         self.regulation_group_list.clear()
 
         for category in regulation_group_library.regulation_group_categories: