Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide a Windows docker image #522

Open
testworksau opened this issue May 8, 2023 · 2 comments
Open

Please provide a Windows docker image #522

testworksau opened this issue May 8, 2023 · 2 comments
Labels
status:needinfo Further information is required type:feature Feature request

Comments

@testworksau
Copy link

We have a need to scan both Windows and Docker images.

Our process up until now has been to use Python to install the ggshield package in a virtual environment on our build agent, but the Docker container is now gaining favour after being hit by this OpenSSL support deprecation in our Amazon Linux CI AMIs.

We'd like to be able to use a ggshield Docker image too, so that we can have a common approach to scanning, and do not have to maintain our own image.

@testworksau testworksau added status:new This issue needs to be reviewed type:feature Feature request labels May 8, 2023
@agateau-gg
Copy link
Collaborator

Just to be make sure I understand correctly: you would like to have a Windows-based Docker image of GGShield? What would it bring compared to the existing Linux-based Docker image?

@agateau-gg agateau-gg added status:needinfo Further information is required and removed status:new This issue needs to be reviewed labels May 17, 2023
@testworksau
Copy link
Author

Hi @agateau-gg 👋🏼

That's correct. In order to build a Windows docker image, we need to use a Windows host.

Windows instances can run Linux and Windows docker containers, but you need to switch the daemon from Windows to Linux to do so (and this means you need to switch it back again to build another Windows container).

Our build agents for Windows are set up to build and run Windows docker containers, and we don't allow switching of the daemon as there are multiple build agents running on the same host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needinfo Further information is required type:feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants