[11.11] Fix double encoding of job name in artifacts download (#773)

* Fix double encoding of $job_name

Removed call to self::encodePath, as the `job` parameter is part of a url query, which is later encoded by `QueryStringBuilder` in `AbstractApi::prepareUri`

* Use `job name` with space to test url encoding

Author: wilkolazki

src/Api/Jobs.php

@@ -151,7 +151,7 @@ public function artifacts($project_id, int $job_id)
     public function artifactsByRefName($project_id, string $ref_name, string $job_name)
     {
         return $this->getAsResponse('projects/'.self::encodePath($project_id).'/jobs/artifacts/'.self::encodePath($ref_name).'/download', [
-            'job' => self::encodePath($job_name),
+            'job' => $job_name,
         ])->getBody();
     }
 
@@ -166,7 +166,7 @@ public function artifactsByRefName($project_id, string $ref_name, string $job_na
     public function artifactByRefName($project_id, string $ref_name, string $job_name, string $artifact_path)
     {
         return $this->getAsResponse('projects/'.self::encodePath($project_id).'/jobs/artifacts/'.self::encodePath($ref_name).'/raw/'.self::encodePath($artifact_path), [
-            'job' => self::encodePath($job_name),
+            'job' => $job_name,
         ])->getBody();
     }
 

tests/Api/JobsTest.php

@@ -171,12 +171,12 @@ public function shouldGetArtifactsByRefName(): void
         $api->expects($this->once())
             ->method('getAsResponse')
             ->with('projects/1/jobs/artifacts/master/download', [
-                'job' => 'job_name',
+                'job' => 'job name',
             ])
             ->will($this->returnValue($returnedStream))
         ;
 
-        $this->assertEquals('foobar', $api->artifactsByRefName(1, 'master', 'job_name')->getContents());
+        $this->assertEquals('foobar', $api->artifactsByRefName(1, 'master', 'job name')->getContents());
     }
 
     /**
@@ -189,11 +189,11 @@ public function shouldGetArtifactByRefName(): void
         $api->expects($this->once())
             ->method('getAsResponse')
             ->with('projects/1/jobs/artifacts/master/raw/artifact_path', [
-                'job' => 'job_name',
+                'job' => 'job name',
             ])
             ->will($this->returnValue($returnedStream))
         ;
-        $this->assertEquals('foobar', $api->artifactByRefName(1, 'master', 'job_name', 'artifact_path')->getContents());
+        $this->assertEquals('foobar', $api->artifactByRefName(1, 'master', 'job name', 'artifact_path')->getContents());
     }
 
     /**